Generic impls access (details 4) #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
proposal rfc
zygoloid
reviewed
Nov 18, 2021
zygoloid
reviewed
Dec 1, 2021
zygoloid
reviewed
Dec 7, 2021
Comment on lines
+85
to
+87
| library full control. We considered and rejected the idea that developers could | ||
| put that interface declaration in an API file to allow it to be referenced in | ||
| named constraints available to users. All impls for that interface would also |
There was a problem hiding this comment.
Is the rejection of this reflected in existing design documents somewhere? This seems like something that would be allowed by default unless we expressly prohibit it, and at least this proposal's design updates don't seem to do so. I'm OK with this rejected alternative being the only record of this for now, especially given that this is listed as something we might want to revisit, but please file an issue to track this so we don't forget entirely.
There was a problem hiding this comment.
I've created #971 with this question.
github-actions
bot
added
proposal accepted
chandlerc
pushed a commit
that referenced
this pull request
Jun 28, 2022
Implementations of interfaces are as public as the names used in their signature. No access control modifiers are allowed on `impl` declarations. Co-authored-by: Richard Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations of interfaces are as public as the names used in their signature. No access control modifiers are allowed on
impldeclarations.