Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): enable processing of historical / missed etcd-backed roster updates #49

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

strieflin
Copy link
Member

Fixes: #15

fix(operator): get rid of unsupported trace logging level

fix(operator): use retries to address race condition on etcd roster updates

fix(operator-chart): remove legacy chart folder incl. migration of changelog updates

fix(operator): use numeric user and group ID in operator dockerfile

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #49 (e07bef2) into master (859f0cb) will increase coverage by 0.15%.
The diff coverage is 74.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   74.55%   74.71%   +0.15%     
==========================================
  Files           7        7              
  Lines        1077     1135      +58     
==========================================
+ Hits          803      848      +45     
- Misses        198      206       +8     
- Partials       76       81       +5     
Impacted Files Coverage Δ
...ator/controllers/tuplegenerationtask_controller.go 75.96% <40.00%> (-0.73%) ⬇️
...rator/controllers/tuplegenerationjob_controller.go 68.03% <75.94%> (+0.16%) ⬆️
...lyshko-operator/controllers/scheduling_strategy.go 100.00% <100.00%> (ø)
...controllers/tuplegenerationscheduler_controller.go 66.39% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 610e82e...e07bef2. Read the comment docs.

@strieflin strieflin marked this pull request as ready for review March 17, 2023 14:33
…oster updates

Fixes: #15

fix(operator): get rid of unsupported trace logging level

fix(operator): use retries to address race condition on etcd roster updates

fix(operator-chart): remove legacy chart folder incl. migration of changelog updates

fix(operator): use numeric user and group ID in operator dockerfile

Signed-off-by: Sven Trieflinger <[email protected]>
Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strieflin strieflin merged commit cf5b0f6 into master Mar 20, 2023
@strieflin strieflin deleted the handle-missed-events branch March 20, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing jobs are not picked up
2 participants