This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 372
Accept a broader range of expiry years #31
Labels
Comments
@dgoldman-ebay IIRC we used to accept cards up to 15 years in the future. Thoughts? |
The greater our tolerance, the fewer complaints we'll get from people entering far-future cards. But we'll also see some increase in incorrect expiry scans for near-future cards being interpreted as farther in the future than they really are. It's a tradeoff, and not one that's easy to quantitate. So if people are going to be complaining about 5 years being too tight a tolerance, I'd lean toward opening things up a bit, but not too much. Based on @AlanYen's googling, how about 8 years? |
8 years SGTM. |
josharian
changed the title
The check rule of expiry is not correct!
Accept a broader range of expiry years
Jul 24, 2015
cysp
added a commit
to cysp/card.io-iOS-source
that referenced
this issue
Sep 14, 2016
+4a94a1cb Forward-declare struct ScannerState for compatibility with the iOS project +4ae1cbf0 Merge pull request card-io#33 from COCUS-NEXT/feature/blur +9a25c052 chore: variable rename: unblur to unblurDigits +45e315dd Update license year and company +d9381ce5 Merge pull request card-io#31 from card-io/dgoldman/master/docs +25369d3f README.md: add pointers to some documentation +3291a212 Merge pull request card-io#28 from COCUS-NEXT/feature/blur +51538328 feat: implement blur in DMZ sources +32d1bc13 Merge pull request card-io#27 from willsteel/master +e4d68dcf fix: Android-source issue card-io#60 +2efa16c5 add x86-64 +269fc2f0 Merge pull request card-io#20 from card-io/android-64-bit +b1c5f508 add 64-bit arm android processor detection
cysp
added a commit
to cysp/card.io-iOS-source
that referenced
this issue
Sep 24, 2016
+324250d4 Forward-declare struct ScannerState for compatibility with the iOS project +05dd0aee Merge pull request card-io#35 from cysp/feature/mastercard-2series +02e1c436 Add MasterCard 2-Series +4ae1cbf0 Merge pull request card-io#33 from COCUS-NEXT/feature/blur +9a25c052 chore: variable rename: unblur to unblurDigits +45e315dd Update license year and company +d9381ce5 Merge pull request card-io#31 from card-io/dgoldman/master/docs +25369d3f README.md: add pointers to some documentation +3291a212 Merge pull request card-io#28 from COCUS-NEXT/feature/blur +51538328 feat: implement blur in DMZ sources +32d1bc13 Merge pull request card-io#27 from willsteel/master +e4d68dcf fix: Android-source issue card-io#60 +2efa16c5 add x86-64 +269fc2f0 Merge pull request card-io#20 from card-io/android-64-bit +b1c5f508 add 64-bit arm android processor detection
cysp
added a commit
to cysp/card.io-iOS-source
that referenced
this issue
Oct 16, 2017
+0aac4a05 Merge pull request card-io#41 from card-io/20170224_standardize_issue_template +0aef13ce Standardize ISSUE_TEMPLATE.md +d3e09c66 Standardize ISSUE_TEMPLATE.md +4a6f5efc Standardize ISSUE_TEMPLATE.md +8c62386a Merge pull request card-io#37 from cysp/feature/ios-compilefix +324250d4 Forward-declare struct ScannerState for compatibility with the iOS project +05dd0aee Merge pull request card-io#35 from cysp/feature/mastercard-2series +02e1c436 Add MasterCard 2-Series +4ae1cbf0 Merge pull request card-io#33 from COCUS-NEXT/feature/blur +9a25c052 chore: variable rename: unblur to unblurDigits +45e315dd Update license year and company +d9381ce5 Merge pull request card-io#31 from card-io/dgoldman/master/docs +25369d3f README.md: add pointers to some documentation +3291a212 Merge pull request card-io#28 from COCUS-NEXT/feature/blur +51538328 feat: implement blur in DMZ sources +32d1bc13 Merge pull request card-io#27 from willsteel/master +e4d68dcf fix: Android-source issue card-io#60 +2efa16c5 add x86-64 +269fc2f0 Merge pull request card-io#20 from card-io/android-64-bit +b1c5f508 add 64-bit arm android processor detection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1).
I found that the check rule of "expiry" is not correct for most of my cards and no scan result in "expiry" field!! (Most of my cards' maximum year of expiry is "2020")
The check rule in function "expiry_string_to_expiry_month_and_year" ( in expiry_categorize.cpp , dmz) is as below, and it is not correct.
2).
I got some information by Google, and it seems that maximum year of expiry may be between 3~8 (usually 5)
The text was updated successfully, but these errors were encountered: