Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP1852 - HD Wallets for Cardano #33

Merged
merged 5 commits into from
Dec 10, 2020

Conversation

SebastienGllmt
Copy link
Contributor

This is a port of input-output-hk/implementation-decisions#18 which was originally written for Jormungandr. This version of the document is for Haskell Shelley and also uses the CIP document structure

This is a slight awkward CIP because it's called CIP1852 despite the fact we definitely don't have 1852 CIPs. The reason this name was chosen is because the CIP process didn't exist at the time this document was written (so there was no way to know which number to use), so instead I just picked the year Ada Lovelace died (to match the fact we used 1815 for her date of birth in the cointype field). This matches the fact that in Bitcoin, the purpose derivation index matches the BIP number for the proposal that describes it.

Using `1852'` as the purpose field, we defined the following derivation path

```
m / purpose' / coin_type' / account' / chain / address_index
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've come to call the last path index simply because I find the word "address" quite confusing since it designate keys, and in some cases, the relation to an address is not direct.

@crptmppt
Copy link
Contributor

crptmppt commented Dec 7, 2020

@SebastienGllmt dir structure 🙏


### Derivation style

Cardano does not use [BIP32](https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki) but actually uses [BIP32-Ed25519](https://cardanolaunch.com/assets/Ed25519_BIP.pdf). The `-Ed25519` suffix is often dropped in practice (ex: we say the Byron release of Cardano supports [BIP44](https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki) but in reality this is BIP44-Ed25519).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cardanolaunch.com/assets/Ed25519_BIP.pdf is a lost page - do we have a different link we can use?
Should we use https://ieeexplore.ieee.org/document/7966967 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there's anywhere to get the PDF without having to pay or creating an account. The old website was hosted by the CF I think, so maybe they have the PDF hosted on a different URL now? Maybe it can be uploaded as part of the IOHK library instead?

CIP-1852/CIP-1852.md Outdated Show resolved Hide resolved
CIP-1852/CIP-1852.md Outdated Show resolved Hide resolved
CIP-1852/CIP-1852.md Show resolved Hide resolved
@crptmppt crptmppt merged commit b9f525a into cardano-foundation:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants