CIP-0025 | Update "image" Spec Based on Feedback #341
Conversation
Practical usage has led to a proliferation of URI mechanisms for the "image" field in CIP-0025 metadata. (See https://twitter.com/pool_pm/status/1575219209491337216?s=20&t=KZKbGeCKIUnPyTZ0fzPyhQ for one thread on the topic). This change would be a simple clarification in one sub-bullet for newly introduced community members looking to get familiar with the standard. Since IPFS and Arweave are the most common methods of data storage for NFT files, we explicitly call them out and provide more resources. Note that this is particularly important as certain free storage providers like NFT.Storage only return the version 1 CID in their file upload calls and lead to scheme being commonly omitted in the URI.
|
This sounds like a reasonable precision. I am not quite sure what you mean with the following sentence:
Would it be worth clarifying with a few explicit example perhaps? Good examples usually help clearing out ambiguity. |
There was a problem hiding this comment.
This seems like a good clarification to have & I would have appreciated it at my own level, especially with the link to OpenSea. Happy to approve pending the detail suggested in #341 (comment).
rphair
added
the
Update
rphair
changed the title
This second commit provides some clarifying language and examples based on initial feedback.
|
I meant "content" not "common" woops (https://github.com/multiformats/cid). Perils of writing late at night. Including more examples and resubmitting. @rphair and @KtorZ let me know feedback on this second commit. I am attaching a photo of how it shows up in stackedit.io
|
apologies to cram this into your branch: just need the clarity for other proofreading...
Additional reviewer feedback.
|
Good callouts. Rebased the branch on top of @rphair's whitespace commit and removed the SVG/updated the link. Feel free to merge whenever this meets the review needs. |
There was a problem hiding this comment.
I'm happy with it & believe it now fully satisfies #341 (comment) 😎
|
Nice. I believe that this also clarifies #345 |
Practical usage has led to a proliferation of URI mechanisms for the "image" field in CIP-0025 metadata. (See
https://twitter.com/pool_pm/status/1575219209491337216?s=20&t=KZKbGeCKIUnPyTZ0fzPyhQ for one thread on the topic). This change would be a simple clarification in one sub-bullet for newly introduced community members looking to get familiar with the standard.
Since IPFS and Arweave are the most common methods of data storage for NFT files, we explicitly call them out and provide more resources. Note that this is particularly important as certain free storage providers like NFT.Storage only return the version 1 CID in their file upload calls and lead to scheme being commonly omitted in the URI.