CIP-0034 | Include legacy testnet #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphair
added
the
Update
rphair
changed the title
KtorZ
approved these changes
Jan 17, 2023
Ryun1
pushed a commit
to Ryun1/CIPs
that referenced
this pull request
Nov 17, 2023
* Include legacy testnet in cip34 * Add space in legacy testnet name * Fix network ID for new testnets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications may still want to refer to the legacy testnet even though it's not running anymore for things like error messages or migrating old configs, but this was made difficult by #332 removing the legacy testnet from the registry.
I propose we keep it there, and just rename it to "legacy testnet"
Additionally, I noticed the networkIDs specified for the new testnets were incorrect. You can see in the Cardano codebase that creating an address calls toShelleyNetwork which sets "Testnet" to 0 in cardano-ledger. If you look at the genesis configs for preprod and preview, they use "Testnet" as the network ID
You can confirm this by looking at explorers like cexplorer which properly show the network ID used in testnets as
0