Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0098? | Distributed Artifact Token Metadata #530

Closed
wants to merge 21 commits into from
Closed

CIP-0098? | Distributed Artifact Token Metadata #530

wants to merge 21 commits into from

Conversation

wout
Copy link

@wout wout commented Jun 30, 2023

In the past one and a half years, I've released three on-chain generative token collections on Cardano, and I developed this standard out of necessity.

Introductory information is available here:
https://docs.venster.art/dats.html

And a slightly more detailed version of this CIP is available here:
https://docs.venster.art/dat-metadata-standard.html

The content of the CIP on our documentation page is the same as in this PR but with a bit more inline information.


Rendered Proposal in Branch

@Ryun1 Ryun1 changed the title CIP-0098? | DAT Metadata Standard CIP-???? | Distributed Artifact Tokens Metadata Standard Jul 2, 2023
@Ryun1 Ryun1 changed the title CIP-???? | Distributed Artifact Tokens Metadata Standard CIP-???? | Distributed Artifact Token Metadata Standard Jul 9, 2023
Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wout, thanks for this interesting proposal!

Please see below the small editorial type comments mainly about the structure of the proposal. And can you rename the directory from CIP-0098 to something like CIP-XXXX or CIP-????.

I do have one larger question:

  • How would this proposal be versioned? since you mention this could be extended over time.

CIP-0098/README.md Outdated Show resolved Hide resolved
CIP-0098/README.md Outdated Show resolved Hide resolved
CIP-0098/README.md Outdated Show resolved Hide resolved
CIP-0098/README.md Outdated Show resolved Hide resolved
CIP-0098/README.md Outdated Show resolved Hide resolved
CIP-0098/README.md Outdated Show resolved Hide resolved
CIP-0098/README.md Outdated Show resolved Hide resolved
CIP-0098/README.md Outdated Show resolved Hide resolved
CIP-0098/README.md Outdated Show resolved Hide resolved
CIP-0098/README.md Outdated Show resolved Hide resolved
wout and others added 20 commits July 10, 2023 14:08
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
@wout
Copy link
Author

wout commented Jul 10, 2023

Thanks for going through it, and sorry for the many individual commits. 😊️

How would this proposal be versioned? since you mention this could be extended over time.

I hoped to discuss this here because I'm unsure how to approach it. Argument directives are a part of the CIP that should be open for additions. If someone comes up with something useful, we should be able to add it.

One idea I had was to use two-part versioning (e.g. MAJOR.MINOR) where MINOR could serve for argument directives. Next year I also want to start looking into how we can extend the DAT metadata standard to CIP-0068. The MAJOR part of the version would be useful there.

The other idea was to extract argument directives from the standard and maintain the list somewhere else. The content of the directives is not important to the standard, only their function is. But this approach would create fragmentation, which I don't like.

So, I'd like to redirect the question back here.

EDIT:
Argument directives are somewhat similar to external dependencies. This standard defines how to structure them, but the actual content is maintained elsewhere.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wout FYI we are introducing this proposal at the CIP editors' meeting today (4PM UTC). I've seen you on Discord there; let me know if any other advocates of this proposal might be there & we can send them a Discord invite.

My preliminary review is:

  • it seems to solve the problem that this deprecated proposal (CIP-0048? | NFT metadata references and payloads #249 (comment)) was trying to solve, without the features that led to its deprecation. Therefore it could be instructive to readers to mention in the Rationale why this earlier considered alternative (adding an "external metadata" tag to existing metadata structures) was unpopular.
  • That proposal was deprecated in favour of the draft CIP-0088 (CIP-0088? | Token Policy Registration #467 (comment)), so could that other CIP approach be compared in the Rationale here as well?

You're not obligated to produce a CPS-like review of the whole problem, but to encourage people to adopt this as a standard it would be proactive to position it favourably compared to other potential solutions.

@rphair
Copy link
Collaborator

rphair commented Aug 1, 2023

@wout I'm about to assign a number to this although the discussion at the meeting today was looking for more confirmation that this is used outside your own organisation.

Until that's established we have to remove the word Standard from the title at least... the feeling so far is that is a good proposal whose documentation can stand on its own in any case & could be merged as such if there's no counter-posting about why this wouldn't work.

Other editors were also interested in seeing a comparative explanation of your approach as requested in #530 (review).

@rphair
Copy link
Collaborator

rphair commented Aug 1, 2023

p.s. update to title requested in https://github.com/venster-io/CIPs/pull/1.
(edit) p.p.s. this will also update the CIP number to the now officially assigned 98.

@rphair rphair changed the title CIP-???? | Distributed Artifact Token Metadata Standard CIP-???? | Distributed Artifact Token Metadata Aug 1, 2023
@rphair rphair changed the title CIP-???? | Distributed Artifact Token Metadata CIP-0098? | Distributed Artifact Token Metadata Aug 1, 2023
@rphair
Copy link
Collaborator

rphair commented Sep 5, 2023

@wout I'm marking this Waiting for Author with no response to #530 (comment) after 5 weeks.

This PR came up in a review out outstanding proposals at the CIP Editors' meeting today and we noted some potential difficulties in passing review resulting from both these conditions:

  • The proposal reflects particular design decisions & preferences which might not also be acceptable to a broader range of implementations.
  • The implementation based on what you've posted as a CIP seems already to be in progress and therefore might not be possible to broaden after the fact.

Please respond about this reservation & what you might be prepared to do about it. We still don't have all editors expressing opinions about this, but it might not be possible to approve this CIP if it's only documenting a single implementation. If we don't have an answer with the usual review time frame we might have to eventually deprecate or close this.

@rphair rphair added the State: Waiting for Author Proposal showing lack of documented progress by authors. label Sep 5, 2023
@wout
Copy link
Author

wout commented Oct 18, 2023

@rphair Sorry for the delayed reply. I'm going through some personal stuff and don't have the headspace for it at the moment.

@rphair
Copy link
Collaborator

rphair commented Oct 19, 2023

Thanks for the update @wout ... feel free to open this again if & when you want to pursue the proposal further.

@rphair rphair closed this Oct 19, 2023
@rphair rphair removed the State: Waiting for Author Proposal showing lack of documented progress by authors. label Oct 19, 2023
rphair added a commit to rphair/CIPs that referenced this pull request Oct 19, 2023
rphair added a commit that referenced this pull request Oct 26, 2023
* promote CIP-0102 and fix some white space there

* set CPS-0007 title to its official title in top README

* author abandoned #530

* added implementors

Co-authored-by: Sam Delaney <[email protected]>

* added extension boilerplate

Co-authored-by: Sam Delaney <[email protected]>

---------

Co-authored-by: Sam Delaney <[email protected]>
Ryun1 pushed a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
…foundation#606)

* promote CIP-0102 and fix some white space there

* set CPS-0007 title to its official title in top README

* author abandoned cardano-foundation#530

* added implementors

Co-authored-by: Sam Delaney <[email protected]>

* added extension boilerplate

Co-authored-by: Sam Delaney <[email protected]>

---------

Co-authored-by: Sam Delaney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants