CPS-0010? | Wallet Connectors #619

Ryun1 · 2023-11-16T20:43:35Z

This problem statement is concerned with the issues surrounding Cardano's current and future wallet connectors.
These interfaces are difficult to define and historically have been even harder to iterate upon.
We wish to provide a comprehensive catalog of the current offerings; and their drawbacks to be able to make suggestions on future standards.

I thought it important that such a problem statement is open for much community input, so have started this as a draft PR.

Todo

Hold first workshop
Hold second workshop
Enrich context subsection
Add to open questions section

Open Questions

~~Can wallet connector standards define when wallets should ask users for permission?~~
- No, this is the responsibility of the wallet, although a separate CIP could define general best practices.
~~Where does the role of transaction building sit?~~
- Will push this question to a subsequent CIP.

📰 Rendered Problem Statement (on fork)

rphair · 2023-11-17T00:55:28Z

@Ryun1 looks promising so far... already as good an inventory of the issue as I could imagine. I'll happily leave it to you when to mark Ready for review and/or kick it off in the CIP meeting agenda.

cps-wallet-connector/README.md

Co-authored-by: Robert Phair <[email protected]>

cps-wallet-connector/README.md

rphair

@Ryun1 one thing that helps keep the lists of CIP and CPS titles concise is not using the word Cardano in the document title when it's already in the CIP/CPS acronym...

cps-wallet-connector/README.md

rphair

as you know @Ryun1 enthusiastically approved as candidate in today's CIP meeting...

cps-wallet-connector/README.md

Co-authored-by: Robert Phair <[email protected]>

cps-wallet-connector/README.md

CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <[email protected]>

CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <[email protected]>

CPS-0010/README.md

Co-authored-by: Vladimir Kalnitsky <[email protected]>

rphair

This proposal looks mature from extended discussion, feedback & update based on repeated reviews. From my point of view nothing could make it any better except 1 more workshop, which @Ryun1 says is coming soon and perhaps some more feedback will come in then. In anticipation of 1 more round of refinement I am clearing the way for this to be merged afterward.

Crypto2099

This has had plenty of time for community feedback and looks to be in a quite complete format for now. I'm sure that future questions and issues may arise as we begin writing CIPs to address this problem, but we can add those in the future.

* Init cps wallet connectors * planned conext section * edits * Add in achknowledgements section from first workshop * Update cps-wallet-connector/README.md Co-authored-by: Robert Phair <[email protected]> * add notes from first workshop * Update cps-wallet-connector/README.md Co-authored-by: Robert Phair <[email protected]> * Update cps-wallet-connector/README.md Co-authored-by: Robert Phair <[email protected]> * Expand definitions of three wallet types * Update cps-wallet-connector/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * Update cps-wallet-connector/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * Update cps-wallet-connector/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * Update cps-wallet-connector/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * Update cps-wallet-connector/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * rename folder to match CPS-10 naming * grammar fixes * detials and responding to comments * UI is not the concern of the connector * Add myself to the list of authors * Fix duplication * Expand open questions * grammar + small notes from second workshop * Apply suggestions from code review Co-authored-by: Robert Phair <[email protected]> * fleshing out missing sections and reorganization * Update CPS-0010/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * Update CPS-0010/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * Update CPS-0010/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * Update CPS-0010/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * Update CPS-0010/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * Update CPS-0010/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * small notes * Update CPS-0010/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * Update CPS-0010/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * Update CPS-0010/README.md Co-authored-by: Vladimir Kalnitsky <[email protected]> * add acknowledgements and notes from workshop 3 * small tidy up * fixed discussion link --------- Co-authored-by: Robert Phair <[email protected]> Co-authored-by: Vladimir Kalnitsky <[email protected]> Co-authored-by: Vladimir Kalnitsky <[email protected]>

Init cps wallet connectors

c3b3762

Ryun1 added the Category: Wallets Proposals belonging to the 'Wallets' category. label Nov 16, 2023

Ryun1 changed the title ~~CIP-???? | Cardano Wallet Connectors [Draft]~~ CPS-???? | Cardano Wallet Connectors [Draft] Nov 16, 2023

planned conext section

b705f18

This was referenced Nov 17, 2023

CIP-???? | Web-Wallet Bridge - Extensive Light Wallet Standard #620

Draft

CIP-0090? | Extendable dApp-Wallet Web Bridge #462

Open

edits

7431833

rphair mentioned this pull request Nov 27, 2023

CIP-???? | Web-Wallet Bridge - Abstraction Layer for DApps #623

Closed

Add in achknowledgements section from first workshop

2cb8d42

rphair reviewed Nov 28, 2023

View reviewed changes

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

Update cps-wallet-connector/README.md

44ac6c4

Co-authored-by: Robert Phair <[email protected]>

Ryun1 changed the title ~~CPS-???? | Cardano Wallet Connectors [Draft]~~ CPS-???? | Cardano Wallet Connectors Nov 28, 2023

add notes from first workshop

7f4ac49

Ryun1 marked this pull request as ready for review November 28, 2023 14:27

klntsky reviewed Nov 28, 2023

View reviewed changes

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

rphair reviewed Nov 28, 2023

View reviewed changes

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

rphair changed the title ~~CPS-???? | Cardano Wallet Connectors~~ CPS-0010? | Wallet Connectors Nov 28, 2023

rphair mentioned this pull request Nov 28, 2023

Update top-level README: post meeting 77 #627

Merged

rphair reviewed Nov 29, 2023

View reviewed changes

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

Ryun1 and others added 2 commits November 29, 2023 08:31

Update cps-wallet-connector/README.md

a1f03fb

Co-authored-by: Robert Phair <[email protected]>

Update cps-wallet-connector/README.md

9d961b6

Co-authored-by: Robert Phair <[email protected]>

klntsky reviewed Nov 29, 2023

View reviewed changes

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

klntsky reviewed Nov 29, 2023

View reviewed changes

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

klntsky reviewed Nov 29, 2023

View reviewed changes

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

klntsky reviewed Nov 29, 2023

View reviewed changes

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

klntsky reviewed Nov 29, 2023

View reviewed changes

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

klntsky reviewed Nov 29, 2023

View reviewed changes

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

klntsky reviewed Nov 29, 2023

View reviewed changes

cps-wallet-connector/README.md Outdated Show resolved Hide resolved

Expand definitions of three wallet types

1ef2a33

klntsky reviewed Jan 5, 2024

View reviewed changes

CPS-0010/README.md Outdated Show resolved Hide resolved

klntsky reviewed Jan 5, 2024

View reviewed changes

CPS-0010/README.md Outdated Show resolved Hide resolved

klntsky reviewed Jan 5, 2024

View reviewed changes

CPS-0010/README.md Outdated Show resolved Hide resolved

klntsky reviewed Jan 5, 2024

View reviewed changes

CPS-0010/README.md Outdated Show resolved Hide resolved

Update CPS-0010/README.md

c80da90

Co-authored-by: Vladimir Kalnitsky <[email protected]>

klntsky reviewed Jan 5, 2024

View reviewed changes

CPS-0010/README.md Outdated Show resolved Hide resolved

Ryun1 and others added 5 commits January 5, 2024 13:34

Update CPS-0010/README.md

0f71bd6

Co-authored-by: Vladimir Kalnitsky <[email protected]>

Update CPS-0010/README.md

bfd2c1f

Co-authored-by: Vladimir Kalnitsky <[email protected]>

Update CPS-0010/README.md

a5c33ac

Co-authored-by: Vladimir Kalnitsky <[email protected]>

Update CPS-0010/README.md

f5fbe5e

Co-authored-by: Vladimir Kalnitsky <[email protected]>

Update CPS-0010/README.md

78c73e7

Co-authored-by: Vladimir Kalnitsky <[email protected]>

klntsky reviewed Jan 5, 2024

View reviewed changes

CPS-0010/README.md Outdated Show resolved Hide resolved

klntsky reviewed Jan 5, 2024

View reviewed changes

CPS-0010/README.md Outdated Show resolved Hide resolved

klntsky reviewed Jan 5, 2024

View reviewed changes

CPS-0010/README.md Outdated Show resolved Hide resolved

Ryun1 and others added 6 commits January 5, 2024 13:55

small notes

7e05b29

Update CPS-0010/README.md

763892d

Co-authored-by: Vladimir Kalnitsky <[email protected]>

Update CPS-0010/README.md

d0ee758

Co-authored-by: Vladimir Kalnitsky <[email protected]>

Update CPS-0010/README.md

f3a141a

Co-authored-by: Vladimir Kalnitsky <[email protected]>

add acknowledgements and notes from workshop 3

5ba6a01

small tidy up

f462c0e

rphair approved these changes Jan 23, 2024

View reviewed changes

fixed discussion link

ef57dae

rphair added the State: Last Check Review favourable with disputes resolved; staged for merging. label Jan 23, 2024

Crypto2099 approved these changes Feb 6, 2024

View reviewed changes

Ryun1 merged commit 56936be into cardano-foundation:master Feb 6, 2024

This was referenced Feb 6, 2024

Update top-level README: post meeting 81 #760

Merged

CIP assets: images missing if in folder itself or for CPSs cardano-foundation/developer-portal#1210

Closed

rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label Sep 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CPS-0010? | Wallet Connectors #619

CPS-0010? | Wallet Connectors #619

Ryun1 commented Nov 16, 2023 •

edited

Loading

rphair commented Nov 17, 2023 •

edited

Loading

rphair left a comment

rphair left a comment

rphair left a comment

Crypto2099 left a comment

CPS-0010? | Wallet Connectors #619

CPS-0010? | Wallet Connectors #619

Conversation

Ryun1 commented Nov 16, 2023 • edited Loading

Todo

Open Questions

rphair commented Nov 17, 2023 • edited Loading

rphair left a comment

Choose a reason for hiding this comment

rphair left a comment

Choose a reason for hiding this comment

rphair left a comment

Choose a reason for hiding this comment

Crypto2099 left a comment

Choose a reason for hiding this comment

Ryun1 commented Nov 16, 2023 •

edited

Loading

rphair commented Nov 17, 2023 •

edited

Loading