Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPS-0014? | Register of CBOR Tags #751

Merged
merged 14 commits into from
Mar 6, 2024
Merged

CPS-0014? | Register of CBOR Tags #751

merged 14 commits into from
Mar 6, 2024

Conversation

stevenj
Copy link
Contributor

@stevenj stevenj commented Jan 24, 2024 •
edited by rphair
Loading

This is the first of three PRs that should be considered together for context.

See also:

Closes input-output-hk#2

(draft rendered from working branch)

@stevenj stevenj marked this pull request as draft January 24, 2024 17:50
@rphair rphair changed the title Cps/cbor tags CPS-???? | Register of CBOR Tags Jan 24, 2024
@rphair rphair added the Category: Meta Proposals belonging to the 'Meta' category. label Jan 24, 2024
Ryun1
Ryun1 reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting problem statement, I believe this to be a genuine problem.
Im keen to hear other opinions on it.

CPS-xxxx/README.md Outdated Show resolved Hide resolved
CPS-xxxx/README.md Outdated Show resolved Hide resolved
CPS-xxxx/README.md Outdated Show resolved Hide resolved
@stevenj stevenj mentioned this pull request Jan 25, 2024
Merged
@rphair rphair added Category: Metadata Proposals belonging to the 'Metadata' category. and removed Category: Meta Proposals belonging to the 'Meta' category. labels Jan 25, 2024
@stevenj stevenj marked this pull request as ready for review January 26, 2024 12:23
@stevenj stevenj mentioned this pull request Jan 26, 2024
Merged
Crypto2099
Crypto2099 approved these changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is well written and looks largely complete from a CPS perspective. Happy to promote this one for consideration at the next meeting and see if we can get it numbered up.

Ryun1
Ryun1 reviewed Feb 4, 2024
View reviewed changes
CPS-xxxx/LICENSE Outdated Show resolved Hide resolved
Ryun1
Ryun1 reviewed Feb 4, 2024
View reviewed changes
CPS-xxxx/README.md Outdated Show resolved Hide resolved
@rphair rphair changed the title CPS-???? | Register of CBOR Tags CPS-0014? | Register of CBOR Tags Feb 6, 2024
rphair
rphair reviewed Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well received along with 2 related CIPs; all promoted to candidates at CIP meeting today. 🎉

rphair
rphair reviewed Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. - the elements of my #751 (review) whose code comments were eaten by GitHub in some unknowable way...

Firstly please delete the LICENSE file from your branch. We're adding licensing to all CPSs with a framework forthcoming as per #759 and before merge we'll probably add a copyright field to the YAML header & Markdown footer.

CPS-xxxx/README.md Outdated Show resolved Hide resolved
@rphair
Copy link
Collaborator

rphair commented Feb 6, 2024

@stevenj we've also had consensus at the CIP meeting today that these CBOR subssions (this and two subsidiary CIPs) should have a category Tools because of their potential to produce & consume these forms across a wide variety of off-chain contexts.

@rphair rphair mentioned this pull request Feb 6, 2024
Merged
rphair
rphair reviewed Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuing #751 (comment):

CPS-xxxx/README.md Outdated Show resolved Hide resolved
@stevenj
Copy link
Contributor Author

stevenj commented Mar 5, 2024

@rphair @Ryun1 This CPS is now numbered properly, and the license notifications have been updated as requested.

This was referenced Mar 5, 2024
Closed
Closed
Ryun1
Ryun1 reviewed Mar 5, 2024
View reviewed changes
CPS-0014/README.md Show resolved Hide resolved
CPS-0014/README.md Outdated Show resolved Hide resolved
@rphair rphair mentioned this pull request Mar 5, 2024
Merged
stevenj and others added 2 commits March 6, 2024 15:16
@stevenj @Ryun1
Update CPS-0014/README.md
4353274 
Co-authored-by: Ryan Williams <[email protected]>
@stevenj @Ryun1
Update CPS-0014/README.md
afe7698 
Co-authored-by: Ryan Williams <[email protected]>
Ryun1
Ryun1 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

rphair
rphair approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All review details apparently addressed as for the related CIPs. 🚀

@rphair rphair merged commit 6fb1bbc into cardano-foundation:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crypto2099 Crypto2099 Crypto2099 approved these changes

@Ryun1 Ryun1 Ryun1 approved these changes

@rphair rphair rphair approved these changes

Assignees
No one assigned
Labels
Category: Metadata Proposals belonging to the 'Metadata' category.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPS for managing tagged CBOR in Cardano metadata
4 participants
@stevenj @rphair @Ryun1 @Crypto2099