Skip to content

Commit

Permalink
docs: Merge #3583 3583: Revise error name to `WithdrawalNotBeneficial…
Browse files Browse the repository at this point in the history
…`. r=jonathanknowles a=jonathanknowles ## Issue Number None. Noticed while reviewing #3555.
 
 ## Description
 
 This PR renames `ErrWithdrawalNotWorth` to `ErrWithdrawalNotBeneficial`.
 
 The wording of the former error name is broken. We _can_ say "a withdrawal is not worth **it**", but saying something is "not worth" (without the "it") just doesn't make sense in English.
 
 ## Compatibility
 
 Usages of the JSON error code `withdrawal_not_worth` are very rare: [Usages of `withdrawal_not_worth`](https://github.com/search?q=org%3Ainput-output-hk+%22withdrawal_not_worth%22&type=code).
 
 These rare cases can easily be updated with a tiny PR or two. Co-authored-by: Jonathan Knowles <[email protected]> Source commit: d59b05e
  • Loading branch information
William King Noel Bot committed Nov 15, 2022
1 parent a7319bc commit 4b13cfd
Show file tree
Hide file tree
Showing 61 changed files with 74 additions and 69 deletions.
2 changes: 1 addition & 1 deletion -/all.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion -/tags.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion -/tasks.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
23 changes: 14 additions & 9 deletions api/edge/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1290,14 +1290,17 @@ x-otherCertificate: &otherCertificate
x-transactionRedemptionRequest: &transactionRedemptionRequest
<<: *walletMnemonicSentence
description: |
When provided, attempts to withdraw rewards from the default stake address corresponding to the given mnemonic.
When provided, attempts to withdraw rewards from the default stake address
corresponding to the given mnemonic.
Should the rewards be null or too small to be worth withdrawing (i.e. the cost of adding them into the transaction
is more than their own intrinsic value), the server will reject the request with a `withdrawal_not_worth` error.
Should the rewards be null or too small to be worth withdrawing (i.e. the
cost of adding them into the transaction is more than their own intrinsic
value), the server will reject the request with a
`withdrawal_not_beneficial` error.
withdrawal field | reward balance | result
--- | --- | ---
any recovery phrase | too small | x Error 403 `withdrawal_not_worth`
any recovery phrase | too small | x Error 403 `withdrawal_not_beneficial`
any recovery phrase | big enough | ✓ withdrawal generated
x-transactionWithdrawalRequestSelf: &transactionWithdrawalRequestSelf
Expand Down Expand Up @@ -2759,7 +2762,7 @@ components:
mint: *ApiAssetMintBurn
burn: *ApiAssetMintBurn
validity_interval: *ApiValidityIntervalExplicit
script_integrity: *scriptIntegrityHash
script_integrity: *scriptIntegrityHash
extra_signatures:
type: array
minItems: 0
Expand Down Expand Up @@ -4994,16 +4997,18 @@ x-errAlreadyWithdrawing: &errAlreadyWithdrawing
enum: ['already_withdrawing']

# TODO: Map this error to the place it belongs.
x-errWithdrawalNotWorth: &errWithdrawalNotWorth
x-errWithdrawalNotBeneficial: &errWithdrawalNotBeneficial
<<: *responsesErr
title: withdrawal_not_worth
title: withdrawal_not_beneficial
properties:
message:
type: string
description: May occur when withdrawing an amount would cost more than the withdrawn value.
description: |
Occurs when the cost of withdrawing a reward balance would be greater
than the reward balance itself.
code:
type: string
enum: ['withdrawal_not_worth']
enum: ['withdrawal_not_beneficial']

# TODO: Map this error to the place it belongs.
x-errPastHorizon: &errPastHorizon
Expand Down
2 changes: 1 addition & 1 deletion archives.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion archives/jormungandr.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion archives/jormungandr/Docker-jormungandr.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/address-derivation.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/byron-address-format.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/coin-selection.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/hierarchical-deterministic-wallets.html
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<script async id='MathJax-script' src='https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js'></script>


<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/master-key-generation.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<script src='https://cdnjs.cloudflare.com/ajax/libs/prism/1.26.0/plugins/autoloader/prism-autoloader.min.js'></script>


<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/recovery-phrases.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<script async id='MathJax-script' src='https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js'></script>


<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/transaction-lifecycle.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</script>


<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion concepts/utxo.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Hydra.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Logging-Guidelines.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Nix.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Notes-from-upgrading-GHC-version.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Release-Process.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Swagger-Development.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Testing.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion contributing/Updating-Dependencies.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/Eras.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/Notes-about-BIP-44.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/Specifying-exceptions-with-Servant-and-Swagger.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/WalletId.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<script async id='MathJax-script' src='https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js'></script>


<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/records.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/records/2021-01-17-nix-flake.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/specs.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion design/specs/light-mode.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</script>


<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion developers.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion developers/Architecture.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</script>


<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion developers/Building.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion developers/Resources.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@



<link href='tailwind.css?instanceId=7067e110-a606-4310-9e57-93a86cb71394' rel='stylesheet' type='text/css' />
<link href='tailwind.css?instanceId=0da3c3c4-780e-474d-9da7-43f22759c323' rel='stylesheet' type='text/css' />

<!-- Heist error element -->
<style type='text/css'>
Expand Down
Loading

0 comments on commit 4b13cfd

Please sign in to comment.