Skip to content

Commit

Permalink
Merge #3360
Browse files Browse the repository at this point in the history
3360: Turn on rest binary calculation tests r=paweljakubas a=paweljakubas

<!--
Detail in a few bullet points the work accomplished in this PR.

Before you submit, don't forget to:

* Make sure the GitHub PR fields are correct:
   ✓ Set a good Title for your PR.
   ✓ Assign yourself to the PR.
   ✓ Assign one or more reviewer(s).
   ✓ Link to a Jira issue, and/or other GitHub issues or PRs.
   ✓ In the PR description delete any empty sections
     and all text commented in <!--, so that this text does not appear
     in merge commit messages.

* Don't waste reviewers' time:
   ✓ If it's a draft, select the Create Draft PR option.
   ✓ Self-review your changes to make sure nothing unexpected slipped through.

* Try to make your intent clear:
   ✓ Write a good Description that explains what this PR is meant to do.
   ✓ Jira will detect and link to this PR once created, but you can also
     link this PR in the description of the corresponding Jira ticket.
   ✓ Highlight what Testing you have done.
   ✓ Acknowledge any changes required to the Documentation.
-->


- [x] turning on Alonzo binary calculation golden test (here we have to adjust binary, as in alonzo we have isValid added to tx)
- [x] turning on Babbage binary calculation golden test (here we need to deal with cddl change for tx outputs in babbage -> https://github.com/input-output-hk/cardano-ledger/blob/74593d426d6f89cfc21d6f66549c5ad18e290177/eras/babbage/test-suite/cddl-files/babbage.cddl#L75 and hence to produce new binaries side by side with the binary from other eras ) 

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number

adp-1885

<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
  Note: Jira issues of the form ADP- will be auto-linked. -->


Co-authored-by: Pawel Jakubas <[email protected]>
  • Loading branch information
iohk-bors[bot] and paweljakubas authored Jun 28, 2022
2 parents d89a7a2 + fc98c3d commit 67e519d
Showing 1 changed file with 252 additions and 69 deletions.
Loading

0 comments on commit 67e519d

Please sign in to comment.