Skip to content

Commit

Permalink
Merge #3500
Browse files Browse the repository at this point in the history
3500: Patched wallet addresses r=paweljakubas a=paweljakubas

<!--
Detail in a few bullet points the work accomplished in this PR.

Before you submit, don't forget to:

* Make sure the GitHub PR fields are correct:
   ✓ Set a good Title for your PR.
   ✓ Assign yourself to the PR.
   ✓ Assign one or more reviewer(s).
   ✓ Link to a Jira issue, and/or other GitHub issues or PRs.
   ✓ In the PR description delete any empty sections
     and all text commented in <!--, so that this text does not appear
     in merge commit messages.

* Don't waste reviewers' time:
   ✓ If it's a draft, select the Create Draft PR option.
   ✓ Self-review your changes to make sure nothing unexpected slipped through.

* Try to make your intent clear:
   ✓ Write a good Description that explains what this PR is meant to do.
   ✓ Jira will detect and link to this PR once created, but you can also
     link this PR in the description of the corresponding Jira ticket.
   ✓ Highlight what Testing you have done.
   ✓ Acknowledge any changes required to the Documentation.
-->

- [x] removing file artefact from previous PR 
- [x] recreating the issue in integration testing
- [x] improve updateCosigner in Cardano.Wallet. Now when transition Pending -> Active occurs the DB is updated for discoveries
- [x] added testing to make sure in active state is works fine 

### Comments

<!-- Additional comments, links, or screenshots to attach, if any. -->

### Issue Number
adp-2219

<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
  Note: Jira issues of the form ADP- will be auto-linked. -->


Co-authored-by: Pawel Jakubas <[email protected]>
Co-authored-by: Piotr Stachyra <[email protected]>
  • Loading branch information
3 people authored Sep 16, 2022
2 parents 50425e2 + 6bbdc8d commit 96915b7
Show file tree
Hide file tree
Showing 5 changed files with 129 additions and 468 deletions.
Loading

0 comments on commit 96915b7

Please sign in to comment.