Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Jörmungandr binary decoder for stake pool registrations #1089

Closed
rvl opened this issue Nov 29, 2019 · 1 comment
Closed

Implement Jörmungandr binary decoder for stake pool registrations #1089

rvl opened this issue Nov 29, 2019 · 1 comment
Assignees
@rvl
Milestone
(WB-25) Collect s...

Comments

@rvl
Copy link
Contributor

rvl commented Nov 29, 2019 •
edited
Loading

Context

We need to decode pool registrations in order to track the mapping from PoolId to PoolOwner.

Decision

In relation to format.abnf, implement decoders for fragments:

  • 5 POOL-REGISTRATION
  • 6 POOL-RETIREMENT

And add them to the Jormungandr block Fragment type.

Note that 7 POOL-UPDATE in the spec is a TODO stub so it can be ignored.

The only information that cardano-wallet requires from pool registrations is:

  • Stake pool ID
  • owner

Acceptance Criteria

  • Pool registrations must be in the jormungandr Block type.
  • Pool retirements must be in the jormungandr Block type.

Development

  1. Move pool retirements out of scope, in to WB-40.
  2. Implement binary decoder as specified ⇒ Binary decoder for stake pool registrations. #1093.
  3. Use jcli to generate golden test data ⇒ Binary decoder for stake pool registrations. #1093

QA

  1. The golden tests for fragments with stake pool registration certificates are in BinarySpec.hs.
@rvl rvl added this to the Collect stake pool metadata milestone Nov 29, 2019
@rvl rvl mentioned this issue Nov 29, 2019
Closed
@rvl rvl self-assigned this Nov 29, 2019
@rvl rvl mentioned this issue Nov 29, 2019
Merged
iohk-bors bot added a commit that referenced this issue Dec 6, 2019
@iohk-bors @rvl
Merge #1093
8532c32 
1093: Binary decoder for stake pool registrations. r=rvl a=rvl

Relates to #1089 

# Overview

 - Adds a binary decoder for stake pool registration certificates.
 - Use jcli to generate golden test data for pool registration fragments.


Co-authored-by: Rodney Lorrimar <[email protected]>
iohk-bors bot added a commit that referenced this issue Dec 6, 2019
@iohk-bors @rvl
Merge #1093
f843315 
1093: Binary decoder for stake pool registrations. r=rvl a=rvl

Relates to #1089 

# Overview

 - Adds a binary decoder for stake pool registration certificates.
 - Use jcli to generate golden test data for pool registration fragments.


Co-authored-by: Rodney Lorrimar <[email protected]>
@piotr-iohk
Copy link
Contributor

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvl rvl

Labels
None yet
Projects
None yet
Milestone
(WB-25) Collect stake pool metadata
Development

No branches or pull requests
2 participants
@rvl @piotr-iohk