Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fee estimation for payments doesn't take fee balancing after selection into account #1150

Closed
1 task done
KtorZ opened this issue Dec 9, 2019 · 0 comments
Closed
1 task done

Fee estimation for payments doesn't take fee balancing after selection into account #1150

KtorZ opened this issue Dec 9, 2019 · 0 comments
Assignees
@KtorZ

Comments

@KtorZ
Copy link
Member

KtorZ commented Dec 9, 2019 •
edited
Loading

Context

Information -
Version b13ddbc
Platform All
Installation N/A

When estimate fee for a standard payment, we stop the estimation after the coin selection. However, adjusting for fees may have an influence on the final fee amount (if change outputs are removed after balancing!)

Steps to Reproduce

N/A

Expected behavior

  • Estimation should take fee balancing into account

Actual behavior

  • Estimation doesn't.

Resolution

QA

  • Function modified, integration tests still pass 👍
@KtorZ KtorZ self-assigned this Dec 9, 2019
@KtorZ KtorZ changed the title Fee estimation for payments doesn't take Fee estimation for payments doesn't take fee balancing after selection into account Dec 9, 2019
@piotr-iohk piotr-iohk mentioned this issue Dec 9, 2019
Closed
@KtorZ KtorZ mentioned this issue Dec 16, 2019
Merged
1 task
iohk-bors bot added a commit that referenced this issue Dec 16, 2019
@iohk-bors @KtorZ
Merge #1191
9a4d4d0 
1191: compute payment fee as the difference between inputs/outputs r=KtorZ a=KtorZ

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

#1150 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] I have re-used the existing coin selection function and removing the need for an extra 'estimateFee' function in the core engine


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <[email protected]>
@KtorZ KtorZ closed this as completed Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KtorZ