Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apparent performance calculation #1006

Merged
merged 8 commits into from
Nov 12, 2019
Merged

Fix apparent performance calculation #1006

merged 8 commits into from
Nov 12, 2019

Commits on Nov 12, 2019

  1. Add "goldens" for calclatePerformance

    @Anviking @KtorZ
    Anviking authored and KtorZ committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    b8bc189 View commit details
    Browse the repository at this point in the history

  2. Fix incorrect apparent_performance calculation 

    For the parameter
>  S - total number of slots in the epoch
we used to sum the total block productions in our `Map PoolId nOfBlocks` map.

This is wrong as empty slots are not represented in the map of block
productions. Summing the map gives us the number of /blocks/ in the
epoch, not number of /slots/.
    @Anviking @KtorZ
    Anviking authored and KtorZ committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    655abe7 View commit details
    Browse the repository at this point in the history

  3. fixup remove derivingvia

    @Anviking @KtorZ
    Anviking authored and KtorZ committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    f92e353 View commit details
    Browse the repository at this point in the history

  4. Make it a property test

    @Anviking @KtorZ
    Anviking authored and KtorZ committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    a617995 View commit details
    Browse the repository at this point in the history

  5. Re-add goldens

    @Anviking @KtorZ
    Anviking authored and KtorZ committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    8fe057a View commit details
    Browse the repository at this point in the history

  6. Re-formating + extra test case

    @Anviking @KtorZ
    Anviking authored and KtorZ committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    c84701b View commit details
    Browse the repository at this point in the history

  7. Re-reformat & remove superflous golden

    @Anviking @KtorZ
    Anviking authored and KtorZ committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    bc25a37 View commit details
    Browse the repository at this point in the history

  8. add one extra golden test case when a pool produces more than expected

    @KtorZ
    KtorZ committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    8765169 View commit details
    Browse the repository at this point in the history