Start IPC channel as soon as the wallet BE socket is available #1009
Conversation
And do not wait for Jörmungandr to be available.
|
bors r+ |
1009: Start IPC channel as soon as the wallet BE socket is available r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have revised the starting order and "dependencies" to make sure that the DaedalusIPC server is started as soon as we know the wallet server port, and before we try to setup the networking layer. - [x] reviewed the starting logic with Daedalus team who confirmed that they have error-handling mechanism in place to actually repeatedly poll the API server after a "Started" message is received via IPC. This is necessary since we'll now be starting the IPC channel much before the API is actually ready. - [x] Since we have disabled the IPC tests in CI, I've made sure they still pass locally. # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
| seqApi <- apiLayer tr seqTl nl | ||
| startServer tr nPort bp rndApi seqApi spl | ||
| Left e -> handleNetworkStartupError e | ||
| Server.withListeningSocket hostPref listen $ \case |
There was a problem hiding this comment.
With this, I think the listening socket will queue connections for API requests, but they will only be accepted once the api server has started.
I do not know what the default listen queue length is.
It may cause problems if Daedalus is polling our API waiting for it to accept connections, depending on how the polling is done.
Maybe a future improvement will be to send ReplyPort only once the API server is ready to accept connections
There was a problem hiding this comment.
Maybe a future improvement will be to send ReplyPort only once the API server is ready to accept connections
Could be 🤔 I know that the Daedalus setup works a bit like a state-machine. I think that, moving forward (mainnet, and likely, the next snapshot release as well), we'll need to review this state machine together and see exactly what's doable and how to better approach this problem.
There was a problem hiding this comment.
Only after we get a response from that very endpoint we start triggering other API requests...
Build succeeded |
Issue Number
Overview
I have revised the starting order and "dependencies" to make sure that the DaedalusIPC server is started as soon as we know the wallet server port, and before we try to setup the networking layer.
reviewed the starting logic with Daedalus team who confirmed that they have error-handling mechanism in place to actually repeatedly poll the API server after a "Started" message is received via IPC. This is necessary since we'll now be starting the IPC channel much before the API is actually ready.
Since we have disabled the IPC tests in CI, I've made sure they still pass locally.
Comments