Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jörmungandr 0.7.0 rc7 -> 0.7.0 #1012

Merged
merged 13 commits into from
Nov 14, 2019
Merged

Jörmungandr 0.7.0 rc7 -> 0.7.0 #1012

merged 13 commits into from
Nov 14, 2019

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Nov 12, 2019 •
edited
Loading

Issue Number

Overview

  • 0.7.0 rc7 -> 0.7.0

Comments

@piotr-iohk piotr-iohk added this to the Usability & Compatibility milestone Nov 12, 2019
@piotr-iohk piotr-iohk self-assigned this Nov 12, 2019
@KtorZ KtorZ requested review from Anviking and KtorZ November 12, 2019 17:22
@KtorZ
Copy link
Member

KtorZ commented Nov 12, 2019

bors try

iohk-bors bot added a commit that referenced this pull request Nov 12, 2019
@iohk-bors
Try #1012:
b9bba75
KtorZ
KtorZ approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anviking approved #1013 from which commits have been cherry-picked.

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 12, 2019

try

Build failed

@KtorZ
Copy link
Member

KtorZ commented Nov 12, 2019 •
edited
Loading

I can also reproduce locally #1012 (comment)

🤔 will look into this.

edit: d1300c0

@piotr-iohk piotr-iohk changed the title Jörmungandr 0.7.0 rc7 -> 0.7.0 (no windows included yet) Jörmungandr 0.7.0 rc7 -> 0.7.0 Nov 12, 2019
@KtorZ
Copy link
Member

KtorZ commented Nov 12, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 12, 2019
@iohk-bors @KtorZ
Merge #1012
4866546 
1012: Jörmungandr 0.7.0 rc7 -> 0.7.0 r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ]  0.7.0 rc7 -> 0.7.0 


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: KtorZ <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 12, 2019

Build failed

@KtorZ
Copy link
Member

KtorZ commented Nov 12, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 12, 2019
@iohk-bors @KtorZ
Merge #1012
07e6766 
1012: Jörmungandr 0.7.0 rc7 -> 0.7.0 r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ]  0.7.0 rc7 -> 0.7.0 


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: KtorZ <[email protected]>
@KtorZ
Copy link
Member

KtorZ commented Nov 12, 2019

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 12, 2019

Canceled

@KtorZ
Copy link
Member

KtorZ commented Nov 12, 2019

bors try

iohk-bors bot added a commit that referenced this pull request Nov 12, 2019
@iohk-bors
Try #1012:
1fa2ce4
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 12, 2019

try

Build succeeded

KtorZ
KtorZ previously requested changes Nov 12, 2019
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 DO NOT MERGE ... yet 🚫

Jörmungandr 0.7.0 won't be deployed for the first phase of the incentivized testnet. Only 0.7.0-rc7 will! So, let's keep this PR hanging a bit in case we need to do some hot fixes for the release to come.

@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

bors r+

@KtorZ KtorZ dismissed their stale review November 14, 2019 10:43

Ok. We can merge now.

iohk-bors bot added a commit that referenced this pull request Nov 14, 2019
@iohk-bors @KtorZ
Merge #1012
3c0a677 
1012: Jörmungandr 0.7.0 rc7 -> 0.7.0 r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ]  0.7.0 rc7 -> 0.7.0 


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <[email protected]>
Co-authored-by: Piotr Stachyra <[email protected]>
@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

I've included #1026 in this PR to save some time merging / testing.

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 14, 2019

Build failed

@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 14, 2019
@iohk-bors @KtorZ
Merge #1012
2493c8e 
1012: Jörmungandr 0.7.0 rc7 -> 0.7.0 r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ]  0.7.0 rc7 -> 0.7.0 


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <[email protected]>
Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 14, 2019

Build failed

@KtorZ
Copy link
Member

KtorZ commented Nov 14, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 14, 2019
@iohk-bors @KtorZ
Merge #1012
25ab1fa 
1012: Jörmungandr 0.7.0 rc7 -> 0.7.0 r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ]  0.7.0 rc7 -> 0.7.0 


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <[email protected]>
Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 14, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit deb5bc7 into master Nov 14, 2019
@KtorZ KtorZ deleted the piotr/rc7_to_0.7.0 branch November 21, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Anviking approved these changes

@KtorZ KtorZ KtorZ left review comments

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
Usability & Compatibility
Development

Successfully merging this pull request may close these issues.
3 participants
@piotr-iohk @KtorZ @Anviking