Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change adjustForFee to account for empty coin selection #1019

Merged
merged 1 commit into from
Nov 13, 2019
Merged

change adjustForFee to account for empty coin selection #1019

merged 1 commit into from
Nov 13, 2019

Conversation

paweljakubas
Copy link
Contributor

@paweljakubas paweljakubas commented Nov 13, 2019 •
edited
Loading

Issue Number

#896

Overview

  • I have adjust adjustForFee to accommodate empty coin selection
  • I have added illustrative unit tests for interesting cases

Comments

@paweljakubas paweljakubas self-assigned this Nov 13, 2019
@KtorZ KtorZ mentioned this pull request Nov 13, 2019
Closed
KtorZ
KtorZ approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KtorZ
Copy link
Member

KtorZ commented Nov 13, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 13, 2019
@iohk-bors @paweljakubas
Merge #1019
c757f40 
1019: change adjustForFee to account for empty coin selection r=KtorZ a=paweljakubas

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->
#896 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] I have adjust `adjustForFee` to accommodate empty coin selection
- [x] I have added illustrative unit tests for interesting cases


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Pawel Jakubas <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 13, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit 7f4a5ab into master Nov 13, 2019
@KtorZ KtorZ deleted the paweljakubas/896/adjustForFee-with-empty-coin-selection branch November 21, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@paweljakubas paweljakubas

Labels
None yet
Projects
None yet
Milestone
Create Delegation Certificate
Development

Successfully merging this pull request may close these issues.
2 participants
@paweljakubas @KtorZ