Make sure application exits when Daedalus IPC channel closes #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:s ... This makes me anxious. |
KtorZ
approved these changes
Nov 14, 2019
|
Sure, we can leave the test disabled. Or - disable it first time there is the failure. We know what it looks like. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 14, 2019
1030: Make sure application exits when Daedalus IPC channel closes r=KtorZ a=rvl # Issue Number TBA # Overview The wallet was failing to exit in time if the DaedalusIPC channel was disconnected during jormungandr's bootstrap phase. This was because it was waiting for bootstrap to complete before exiting. - This change makes the wallet exit as soon as the DaedalusIPC channel is closed. # Comments - I have undisabled the integration test for DaedalusIPC and added a patch that should hopefully prevent the random test failures due to HPC. Co-authored-by: Rodney Lorrimar <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
TBA
Overview
The wallet was failing to exit in time if the DaedalusIPC channel was disconnected during jormungandr's bootstrap phase. This was because it was waiting for bootstrap to complete before exiting.
Comments