Increase artificialEpochLength to maxBound :: Word32
#1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
commented
Nov 18, 2019
|
I removed the pool sqlite types module altogether, because it is a subset of the wallet sqlite types module (except for the bug which was fixed in one but not the other). The state machine model tests could have picked up the error, were the SlotId generator not limiting slot numbers to the range 0-10. |
jonathanknowles
approved these changes
Nov 19, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 19, 2019
1046: Increase artificialEpochLength to `maxBound :: Word32` r=jonathanknowles a=Anviking # Issue Number Bug to be created. In the mean-time https://input-output-rnd.slack.com/archives/GBT05825V/p1574113682014100 # Overview - [x] I have increased `artificialEpochLength` to `maxBound :: Word32` # Comments - I thought the explicit `:: Word16` annotation was intentional from the beginning, but its usefulness could now be debated. -⚠️ Regression test to be added. Why wasn't this caught by existing tests somehow? <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
Build succeeded |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1025
Bug to be created.In the mean-time https://input-output-rnd.slack.com/archives/GBT05825V/p1574113682014100Overview
artificialEpochLengthtomaxBound :: Word32Comments
:: Word16annotation was intentional from the beginning, but its usefulness could now be debated.