Scan stake pool registrations during wallet restoration. #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
suggested changes
Nov 20, 2019
jonathanknowles
force-pushed
the
jonathanknowles/scan-pool-registrations-during-restoration
branch
from
75111f5
to
0a6850d
Compare
jonathanknowles
force-pushed
the
jonathanknowles/block-delegations
branch
from
6d26526
to
0e6b3cd
Compare
jonathanknowles
force-pushed
the
jonathanknowles/scan-pool-registrations-during-restoration
branch
from
0a6850d
to
51bb22f
Compare
|
@jonathanknowles why is this one still a draft + WIP ? Is it actually ready for review, what are the next steps? |
2 tasks
jonathanknowles
force-pushed
the
jonathanknowles/block-delegations
branch
from
0e6b3cd
to
7a06c5e
Compare
Because I had put this on hold (temporarily) to work on other things. (Namely: PR #1057).
Understood. I'll update this shortly.
Not yet.
Three things:
|
jonathanknowles
force-pushed
the
jonathanknowles/scan-pool-registrations-during-restoration
branch
from
51bb22f
to
84bf451
Compare
jonathanknowles
changed the base branch from
jonathanknowles/block-delegations
to
master
KtorZ
reviewed
Nov 25, 2019
jonathanknowles
force-pushed
the
jonathanknowles/scan-pool-registrations-during-restoration
branch
13 times, most recently
from
2220460
to
3f7de4c
Compare
8 tasks
jonathanknowles
force-pushed
the
jonathanknowles/scan-pool-registrations-during-restoration
branch
from
3f7de4c
to
66a085d
Compare
jonathanknowles
force-pushed
the
jonathanknowles/scan-pool-registrations-during-restoration
branch
from
94e7d01
to
75e139a
Compare
KtorZ
reviewed
Nov 28, 2019
| isOurs (ChimericAccount account) state = | ||
| (account == ourAccount, state) | ||
| where | ||
| ourAccount = xpubPublicKey $ getRawKey $ rewardAccountKey state |
Fix comment for function `putDelegationCertificate`. Fix comment for function `applyBlock`. Fix comment for function `prefilterBlock`.
Use this type to replace the list of transactions returned by `applyBlock` and `applyBlocks`. Future changes will add more fields to this type.
This represents the set of stake delegations made on behalf of the wallet, listed in order of discovery.
For the moment, we return an empty list for the list of delegations.
When restoring blocks. Additionally, write a log entry for each certificate discovered.
KtorZ
force-pushed
the
jonathanknowles/scan-pool-registrations-during-restoration
branch
from
a676584
to
2c31cbd
Compare
KtorZ
changed the title
|
I've noted a quite important change to do when storing the delegation after discovery, but I'll make it another PR to keep this one concise. It doesn't affect the core functionality, but is important in terms of reliability and data consistency. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 28, 2019
1050: Scan stake pool registrations during wallet restoration. r=KtorZ a=jonathanknowles # Issue Number #899 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> I have: - [x] Provided an implementation of `IsOurs (SeqState n k) ChimericAccount`. - [x] Adjusted the return type of `applyBlock` so that it references any stake delegation that has occurred on behalf of the specified wallet. - [x] Adjusted the definition of `restoreBlocks` so that it correctly processes the registrations returned by `applyBlocks`. - [x] Adjusted the definition of `applyBlock` to identify delegations relevant to the specified wallet, and return the final registration as part of `FilteredBlock`. - [x] Added tests to ensure that `applyBlock` does successfully discover delegations made by the wallet under test, and only that wallet. - [x] Added tests to ensure that a wallet's delegation status is correctly updated in the context of discovered delegations. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Jonathan Knowles <[email protected]> Co-authored-by: KtorZ <[email protected]>
Build failed |
6 tasks
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 28, 2019
1050: Scan stake pool registrations during wallet restoration. r=KtorZ a=jonathanknowles # Issue Number #899 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> I have: - [x] Provided an implementation of `IsOurs (SeqState n k) ChimericAccount`. - [x] Adjusted the return type of `applyBlock` so that it references any stake delegation that has occurred on behalf of the specified wallet. - [x] Adjusted the definition of `restoreBlocks` so that it correctly processes the registrations returned by `applyBlocks`. - [x] Adjusted the definition of `applyBlock` to identify delegations relevant to the specified wallet, and return the final registration as part of `FilteredBlock`. - [x] Added tests to ensure that `applyBlock` does successfully discover delegations made by the wallet under test, and only that wallet. - [x] Added tests to ensure that a wallet's delegation status is correctly updated in the context of discovered delegations. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Jonathan Knowles <[email protected]> Co-authored-by: KtorZ <[email protected]>
Build succeeded |
KtorZ
deleted the
jonathanknowles/scan-pool-registrations-during-restoration
branch
iohk-bors bot
added a commit
that referenced
this pull request
Nov 29, 2019
1080: Implement quit stake pool r=paweljakubas a=paweljakubas # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1074 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have handled NotDelegating case - [x] I have handled NoSuchPool case - [x] I have renamed mkDelegationCertTx to mkDelegationJoinTx and added new mkDelegationQuitTx - [x] I have added corresponding golden tests (if possible) - [x] I have reused create/sign functions in quitStakePool func - [x] I have adjusted integration tests (after #1050 is merged) # Comments <!-- Additional comments or screenshots to attach if any --> I do not think it is easy to add corresponding golden tests here <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Pawel Jakubas <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#899
Overview
I have:
IsOurs (SeqState n k) ChimericAccount.applyBlockso that it references any stake delegation that has occurred on behalf of the specified wallet.restoreBlocksso that it correctly processes the registrations returned byapplyBlocks.applyBlockto identify delegations relevant to the specified wallet, and return the final registration as part ofFilteredBlock.applyBlockdoes successfully discover delegations made by the wallet under test, and only that wallet.