Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Github templates and README #1052

Merged
merged 4 commits into from
Nov 20, 2019
Merged

Review Github templates and README #1052

merged 4 commits into from
Nov 20, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Nov 20, 2019 •
edited
Loading

Issue Number

N/A

Overview

  • I have updated the RELEASE_TEMPLATE.md to be more up-to-date
  • I have remove some superfluous stuff from out templates that are not really used effectively:
    • The 'PR' and 'Development Plan' sections have been merged into one 'Development' section containing both. Which is an approach we've been using more and more and tends to be clearer.
    • Revised a bit the template for the bug report
  • Created a new "failing case" template that'll be available when creating an issue. Often enough, the template for the bug report was quite awkward when reporting a failing test case...
  • Added a compatibility matrix to our README with the latest 3 releases.

Comments

The main goal was really to update the release notes with a small "troubleshooting" section in order to close #923 and while at it, I thought of it'd be a good opportunity to update other templates with changes I wanted to do for a long long time!

@KtorZ KtorZ self-assigned this Nov 20, 2019
@piotr-iohk piotr-iohk mentioned this pull request Nov 20, 2019
Closed
piotr-iohk
piotr-iohk approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@KtorZ KtorZ merged commit fe49be8 into master Nov 20, 2019
@KtorZ KtorZ deleted the KtorZ/review-templates-and-readme branch November 20, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-iohk piotr-iohk piotr-iohk approved these changes

Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CentOS, RHEL 6+ and SuSe Linux defect for libcrypto.so.1.0.0
2 participants
@KtorZ @piotr-iohk