-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nextEpoch
field to ApiNetworkInformation
type.
#1122
Merged
iohk-bors
merged 5 commits into
master
from
jonathanknowles/api-network-information-next-epoch
Dec 6, 2019
Merged
Add nextEpoch
field to ApiNetworkInformation
type.
#1122
iohk-bors
merged 5 commits into
master
from
jonathanknowles/api-network-information-next-epoch
Dec 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/api-network-information-next-epoch
branch
from
December 5, 2019 07:36
587cbff
to
c8e816d
Compare
jonathanknowles
changed the title
WIP: Add
Add Dec 5, 2019
nextEpoch
field to ApiNetworkInformation
type.nextEpoch
field to ApiNetworkInformation
type.
jonathanknowles
force-pushed
the
jonathanknowles/api-network-information-next-epoch
branch
from
December 5, 2019 07:39
c8e816d
to
9021169
Compare
5 tasks
jonathanknowles
force-pushed
the
jonathanknowles/api-network-information-next-epoch
branch
from
December 5, 2019 08:44
9021169
to
11e6ed1
Compare
paweljakubas
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jonathanknowles
force-pushed
the
jonathanknowles/api-network-information-next-epoch
branch
from
December 6, 2019 00:57
11e6ed1
to
070cc81
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 6, 2019
1122: Add `nextEpoch` field to `ApiNetworkInformation` type. r=jonathanknowles a=jonathanknowles # Issue Number #1088 # Overview This PR: - [x] Adds a function `calculateNextEpoch`, which calculates the next epoch after the specified time. - [x] Adds a `nextEpoch` field to the `ApiNetworkInformation` type. - [x] Updates integration tests to check that the `nextEpoch` field is present and valid. # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Jonathan Knowles <[email protected]>
Build succeeded |
jonathanknowles
deleted the
jonathanknowles/api-network-information-next-epoch
branch
December 6, 2019 03:16
KtorZ
added this to the (WB-33) Next epoch available when querying network information milestone
Dec 9, 2019
This was referenced Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1088
Overview
This PR:
calculateNextEpoch
, which calculates the next epoch after the specified time.nextEpoch
field to theApiNetworkInformation
type.nextEpoch
field is present and valid.Comments