Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextEpoch field to ApiNetworkInformation type. #1122

Merged

Conversation

jonathanknowles
Copy link
Member

@jonathanknowles jonathanknowles commented Dec 5, 2019

Issue Number

#1088

Overview

This PR:

  • Adds a function calculateNextEpoch, which calculates the next epoch after the specified time.
  • Adds a nextEpoch field to the ApiNetworkInformation type.
  • Updates integration tests to check that the nextEpoch field is present and valid.

Comments

@jonathanknowles jonathanknowles self-assigned this Dec 5, 2019
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/api-network-information-next-epoch branch from 587cbff to c8e816d Compare December 5, 2019 07:36
@jonathanknowles jonathanknowles changed the title WIP: Add nextEpoch field to ApiNetworkInformation type. Add nextEpoch field to ApiNetworkInformation type. Dec 5, 2019
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/api-network-information-next-epoch branch from c8e816d to 9021169 Compare December 5, 2019 07:39
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/api-network-information-next-epoch branch from 9021169 to 11e6ed1 Compare December 5, 2019 08:44
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathanknowles jonathanknowles force-pushed the jonathanknowles/api-network-information-next-epoch branch from 11e6ed1 to 070cc81 Compare December 6, 2019 00:57
@jonathanknowles
Copy link
Member Author

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 6, 2019
1122: Add `nextEpoch` field to `ApiNetworkInformation` type. r=jonathanknowles a=jonathanknowles

# Issue Number

#1088 

# Overview

This PR:

- [x] Adds a function `calculateNextEpoch`, which calculates the next epoch after the specified time.
- [x] Adds a `nextEpoch` field to the `ApiNetworkInformation` type.
- [x] Updates integration tests to check that the `nextEpoch` field is present and valid.

# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Jonathan Knowles <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 6, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit 070cc81 into master Dec 6, 2019
@jonathanknowles jonathanknowles deleted the jonathanknowles/api-network-information-next-epoch branch December 6, 2019 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants