neat-picks on README #1128
Merged
neat-picks on README #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove coverall badge until we restore it - Add a section 'how to install' - Point 'how to build' to the wiki - Rename 'compatibility matrix' to 'latest releases' and nest it under 'how to install'
Anviking
reviewed
Dec 5, 2019
Co-Authored-By: anviking <[email protected]>
Anviking
approved these changes
Dec 5, 2019
|
|
||
| > ### Latest releases | ||
| > | ||
| > | cardano-wallet | Jörmungandr | |
There was a problem hiding this comment.
What if the table header Jörmungandr was supported Jörmungandr to highlight the relationship between the two?
There was a problem hiding this comment.
Additionally it might be worth a sentence in "Overview" explaining what Jörmungandr is.
(Imagining people landing here randomly might be unclear about what jormungandr is, and maybe people coming here for the testnet could be confused by the current generic overview which doesn't mention the testnet or jormungandr)
There was a problem hiding this comment.
You have a point! I am only seeing your comment now though :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
N/A
Overview
under 'how to install'
Comments