Update dependencies #3038
Closed
Update dependencies #3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @kk-hainq - we were going to wait until cardano-node 1.32.0 before updating. But please let us know if it's ready to review. |
|
@rvl Thank you for the confirmation. This is just a sample draft from our fork to proceed for now. I think the actual update would need to be several more modular PRs. I guess something like #3023 would be a better start. In the meantime, we could also open a no-op PR that removes unused dependencies/sub dirs/Nix files if you would accept one? |
|
Closed in favour of #3050 (thank you!!). |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 15, 2021
3050: Bump cardano-node to 1.32.1 r=rvl a=rvl Updates to [cardano-node 1.32.1](https://github.com/input-output-hk/cardano-node/releases/tag/1.32.1) Release notes for [1.31.0](https://github.com/input-output-hk/cardano-node/releases/tag/1.31.0). - [x] Updates cardano-node version in `stack.yaml`. - [x] Updates cardano-node version in `cabal.project`. - [x] Fix new build errors. - [x] Fix any test failures. - [x] Update readme. ### Comments - [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-3050) See also: #3023 #3038 ### Issue Number ADP-1266 Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Jann Müller <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Dec 15, 2021
3050: Bump cardano-node to 1.32.1 r=rvl a=rvl Updates to [cardano-node 1.32.1](https://github.com/input-output-hk/cardano-node/releases/tag/1.32.1) Release notes for [1.31.0](https://github.com/input-output-hk/cardano-node/releases/tag/1.31.0). - [x] Updates cardano-node version in `stack.yaml`. - [x] Updates cardano-node version in `cabal.project`. - [x] Fix new build errors. - [x] Fix any test failures. - [x] Update readme. ### Comments - [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-3050) See also: #3023 #3038 ### Issue Number ADP-1266 Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Jann Müller <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less a proof-of-concept to bump the dependencies of this repository. There have been several breaking changes, mainly from
cardano-ledgerandcardano-nodeso this is non-trivial with several undecidedfixmes here and there. I've also been able to clean many Nix files by removing unused Plutus subdirs. I suspect we can still trim a lot more across the board.Context:
cardano-walletis now a dependency ofplutus-apps, making these bumps useful for dApp developers who aggressively bumpplutus-appsthemselves (for new PAB commits, node fixes, etc). While this is not critical and we have no preferences on how to handle it, both #3023 and this would be very useful to dApp developers. We are willing to contribute in any way we can as well.Jira Issue
ADP-1266