Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on heap profile in restoration benchmarks #3061

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Turn on heap profile in restoration benchmarks #3061

merged 1 commit into from
Dec 21, 2021

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Dec 15, 2021 •
edited
Loading

  • I have turned on heap profile plot in restoration benchmark

Comments

Hopefully it will work now with slimmer benchmarks.

Testing: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1188 🟢 👈 it works!

Issue Number

Follow up to #3051 / ADP-1307.

@piotr-iohk piotr-iohk self-assigned this Dec 15, 2021
@piotr-iohk piotr-iohk requested a review from rvl December 16, 2021 12:51
paweljakubas
paweljakubas approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 21, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit c5a5afe into master Dec 21, 2021
@iohk-bors iohk-bors bot deleted the piotr/turn/on/memory/plot branch December 21, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@rvl rvl Awaiting requested review from rvl

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-iohk @paweljakubas