Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve asset assertion in e2e tests #3067

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Improve asset assertion in e2e tests #3067

merged 3 commits into from
Dec 21, 2021

Conversation

piotr-iohk
Copy link
Contributor

  • I have improved assertion checking asset balance after tx so it is possible to assert specific asset balance

Comments

This is to get rid of potential false positives when there are some more assets on fixture wallets.

Issue Number

@piotr-iohk piotr-iohk self-assigned this Dec 20, 2021
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 21, 2021
3067: Improve asset assertion in e2e tests r=piotr-iohk a=piotr-iohk


- [ ] I have improved assertion checking asset balance after tx so it is possible to assert specific asset balance

### Comments

This is to get rid of potential false positives when there are some more assets on fixture wallets.

### Issue Number

<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
  Note: Jira issues of the form ADP- will be auto-linked. -->


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 21, 2021

Build failed:

--
  | 1) CLI Specifications, SHELLEY_CLI_TRANSACTIONS, TRANS_ESTIMATE_09 - Invalid amount, -1000
  | uncaught exception: IOException of type ResourceVanished
  | fd:158: hFlush: resource vanished (Broken pipe)
  |  

#2855

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 21, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 0cda978 into master Dec 21, 2021
@iohk-bors iohk-bors bot deleted the piotr/fix-tests branch December 21, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants