Server: Update windows error codes list #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case for `withListeningSocket "patate" ListenOnRandomPort` was sometimes failing with "Network.Socket.gai_strerror not supported: 11002".
paweljakubas
approved these changes
Feb 10, 2022
|
bors r+ 🤞 |
1 task
iohk-bors bot
added a commit
that referenced
this pull request
Feb 10, 2022
3074: Fix gitRevFromGit with newer process libraries r=rvl a=angerman
This code was initially lifted likely from cardano-node, and now lives in cardano-config, but is replicated here...
It was fixed in cardano config recently by `@newhoggy` in cardano-config#4. Now we need to fix it here as well.
3110: select witnesses only for unique inps r=paweljakubas a=paweljakubas
<!--
Detail in a few bullet points the work accomplished in this PR.
Before you submit, don't forget to:
* Make sure the GitHub PR fields are correct:
✓ Set a good Title for your PR.
✓ Assign yourself to the PR.
✓ Assign one or more reviewer(s).
✓ Link to a Jira issue, and/or other GitHub issues or PRs.
✓ In the PR description delete any empty sections
and all text commented in <!--, so that this text does not appear
in merge commit messages.
* Don't waste reviewers' time:
✓ If it's a draft, select the Create Draft PR option.
✓ Self-review your changes to make sure nothing unexpected slipped through.
* Try to make your intent clear:
✓ Write a good Description that explains what this PR is meant to do.
✓ Jira will detect and link to this PR once created, but you can also
link this PR in the description of the corresponding Jira ticket.
✓ Highlight what Testing you have done.
✓ Acknowledge any changes required to the Documentation.
-->
adp-1190
- [x] I have laxed condition when checking if tx is partially signed. We take into consideration only unique inputs now
- [x] Integration test
### Comments
<!-- Additional comments, links, or screenshots to attach, if any. -->
### Issue Number
<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
Note: Jira issues of the form ADP- will be auto-linked. -->
3125: Server: Update windows error codes list r=rvl a=rvl
When testing the windows build under wine, the test case for `withListeningSocket "patate" ListenOnRandomPort` was sometimes failing with "Network.Socket.gai_strerror not supported: 11002". This PR should fix it.
### Issue Number
ADP-1432
Co-authored-by: Moritz Angermann <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: IOHK <[email protected]>
Co-authored-by: Pawel Jakubas <[email protected]>
Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: Johannes Lund <[email protected]>
|
This PR was included in a batch that timed out, it will be automatically retried #duplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the windows build under wine, the test case for
withListeningSocket "patate" ListenOnRandomPortwas sometimes failing with "Network.Socket.gai_strerror not supported: 11002". This PR should fix it.Issue Number
ADP-1432