Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: Fix source filtering on latency benchmark #3135

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Feb 14, 2022

The latency benchmark needs test data files, but they were getting removed by haskell-nix.haskellSourceFilter.

Comments

Tested with:

nix build .#benchmarks.cardano-wallet.latency && ./result/bin/latency

Issue Number

ADP-1444

@rvl rvl requested review from jbgi and piotr-iohk February 14, 2022 13:10
@rvl rvl self-assigned this Feb 14, 2022
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

$ ./.buildkite/bench-latency.sh
--- Build
+++ Run benchmark - shelley
...
        getNetworkInfo      - 26.1 ms
    Latencies for 2 fixture wallets scenario
        listWallets         - 1.8 ms
        getWallet           - 0.5 ms
        getUTxOsStatistics  - 0.4 ms
...

@rvl rvl merged commit f4883c9 into master Feb 15, 2022
@rvl rvl deleted the rvl/adp-1444/fix-latency-benchmark branch February 15, 2022 01:17
WilliamKingNoel-Bot pushed a commit that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants