Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all remaining usages of TxOut from coin selection implementation. #3158

Merged

Conversation

jonathanknowles
Copy link
Member

@jonathanknowles jonathanknowles commented Mar 1, 2022

Issue Number

ADP-1482

Summary

This PR removes all remaining usages of TxOut from the following modules:

  • CoinSelection.Internal
  • CoinSelection.Internal.Balance

Background

This work is part of ADP-1448, the goal of which is to generalize the types used by coin selection, so that coin selection modules do not depend on the Address, TxIn, TxOut, or UTxO types.

@jonathanknowles jonathanknowles self-assigned this Mar 1, 2022
@Anviking
Copy link
Member

Anviking commented Mar 1, 2022

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 1, 2022
3158: Remove all remaining usages of `TxOut` from coin selection implementation. r=Anviking a=jonathanknowles

## Issue Number

ADP-1482

## Summary

This PR removes all remaining usages of `TxOut` from the following modules:
- `CoinSelection.Internal`
- `CoinSelection.Internal.Balance`

## Background

This work is part of ADP-1448, the goal of which is to generalize the types used by coin selection, so that coin selection modules do not depend on the `Address`, `TxIn`, `TxOut`, or `UTxO` types.

Co-authored-by: Jonathan Knowles <[email protected]>
@jonathanknowles
Copy link
Member Author

bors cancel

@jonathanknowles
Copy link
Member Author

bors r-

@jonathanknowles
Copy link
Member Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 2, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 56917c2 into master Mar 2, 2022
@iohk-bors iohk-bors bot deleted the jonathanknowles/remove-txout-references-from-coin-selection branch March 2, 2022 04:43
WilliamKingNoel-Bot pushed a commit that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants