Bump cardano-node to 1.34.1 #3160

Anviking · 2022-03-03T20:06:56Z

Bump node to 1.34.1
- Bump node
- Tweak readme
- Fix a few new compilation warnings/errors
Drop support for stack build
- Tweak docs
- Remove stack build step from buildkite CI

Comments

~~Blocked by stack + sublib problem~~

Guided by git diff 1.33.0 1.34.0 -- cabal.project in cardano-node

Issue Number

ADP-1433

jonathanknowles

Looks very reasonable to me. 👍🏻

I'm guessing that all of the nix/materialized/stack-nix/.stack-to-nix.cache.* files were updated automatically, via nix/regenerate.sh?

Should the title of this PR be "Bump cardano-node to 1.34.1", given the changes within the README.md?

Anviking · 2022-03-15T13:46:06Z

bors try

iohk-bors · 2022-03-15T18:53:35Z

try

Timed out.

Anviking · 2022-03-16T11:00:08Z

bors try

iohk-bors · 2022-03-16T11:49:25Z

try

Build succeeded:

docs/developers/Building.md

sevanspowell

Looks good to me 👍

Anviking · 2022-03-17T08:48:22Z

bors r+

3160: Bump cardano-node to 1.34.1 r=Anviking a=Anviking - [x] Bump node to 1.34.1 - [x] Bump node - [x] Tweak readme - [x] Fix a few new compilation warnings/errors - [x] Drop support for `stack build` - Tweak docs - Remove `stack build` step from buildkite CI ### Comments <s>Blocked by `stack` + sublib problem</s> Guided by `git diff 1.33.0 1.34.0 -- cabal.project` in `cardano-node` ### Issue Number ADP-1433 Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: IOHK <[email protected]> Co-authored-by: Samuel Evans-Powell <[email protected]>

iohk-bors · 2022-03-17T09:18:36Z

Build failed:

ci/hydra-build:required

  src/Test/Integration/Scenario/API/Shelley/TransactionsNew.hs:2116:54: 
  1) API Specifications, NEW_SHELLEY_TRANSACTIONS, Plutus scenarios, withdrawal
       uncaught exception: ProcessHasExited
       ProcessHasExited "cardano-cli failed: Command failed: transaction submit  Error: Error while submitting tx: ShelleyTxValidationError ShelleyBasedEraAlonzo (ApplyTxError [DelegsFailure (DelplFailure (DelegFailure (StakeKeyAlreadyRegisteredDELEG (ScriptHashObj (ScriptHash \"1b8374d0b294a4a3399ff25f06a0707b16214f1e9b67cf89ba2454a6\")))))])\n" (ExitFailure 1)

  To rerun use: --match "/API Specifications/NEW_SHELLEY_TRANSACTIONS/Plutus scenarios/withdrawal/"

#3057

Anviking · 2022-03-17T09:56:46Z

bors r+

3160: Bump cardano-node to 1.34.1 r=Anviking a=Anviking - [x] Bump node to 1.34.1 - [x] Bump node - [x] Tweak readme - [x] Fix a few new compilation warnings/errors - [x] Drop support for `stack build` - Tweak docs - Remove `stack build` step from buildkite CI ### Comments <s>Blocked by `stack` + sublib problem</s> Guided by `git diff 1.33.0 1.34.0 -- cabal.project` in `cardano-node` ### Issue Number ADP-1433 Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: IOHK <[email protected]> Co-authored-by: Samuel Evans-Powell <[email protected]>

- Workaround haskell.nix issue (input-output-hk/haskell.nix#1402) by using an earlier version of haskell.nix.

Anviking · 2022-03-17T16:16:53Z

bors r+

3160: Bump cardano-node to 1.34.1 r=Anviking a=Anviking - [x] Bump node to 1.34.1 - [x] Bump node - [x] Tweak readme - [x] Fix a few new compilation warnings/errors - [x] Drop support for `stack build` - Tweak docs - Remove `stack build` step from buildkite CI ### Comments <s>Blocked by `stack` + sublib problem</s> Guided by `git diff 1.33.0 1.34.0 -- cabal.project` in `cardano-node` ### Issue Number ADP-1433 Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: IOHK <[email protected]> Co-authored-by: Samuel Evans-Powell <[email protected]>

iohk-bors · 2022-03-17T18:03:11Z

Build failed:

ci/hydra-build:required

Failures:

  test/unit/Cardano/Wallet/Shelley/Launch/BlockfrostSpec.hs:37:27: 
  1) Cardano.Wallet.Shelley.Launch.Blockfrost, Blockfrost CLI options, modeOption --node-socket
       ParserFailure(option --node-socket: Invalid pipe name. Windows named pipes are of the form \\.\pipe\cardano-node
       
       Usage: <program> (--node-socket PIPENAME | --light --blockfrost-token-file FILE),ExitFailure 1,80)

  To rerun use: --match "/Cardano.Wallet.Shelley.Launch.Blockfrost/Blockfrost CLI options/modeOption --node-socket/"

  test/unit/Cardano/Wallet/Shelley/Launch/BlockfrostSpec.hs:61:17: 
  2) Cardano.Wallet.Shelley.Launch.Blockfrost, Blockfrost CLI options, modeOption requires --light flag
       expected: "Missing: --light\n\nUsage:  (--node-socket FILE | --light --blockfrost-token-file FILE)"
        but got: "Missing: --light\n\nUsage:  (--node-socket PIPENAME | --light --blockfrost-token-file FILE)"

  To rerun use: --match "/Cardano.Wallet.Shelley.Launch.Blockfrost/Blockfrost CLI options/modeOption requires --light flag/"

Randomized with seed 1502943060

Anviking · 2022-03-17T19:48:04Z

bors r+

iohk-bors · 2022-03-17T21:57:23Z

Build succeeded:

3229: Ensure 1.34.1 node bump is reflected in cabal.project r=Anviking a=Anviking - [x] Update cabal.project revisions which should have been updated in #3160 - This affects `cabal build` **outside** of `nix`. - [x] Check that CI check passes ### Comments - Prompted by and includes #3225 - Note: cabal build outside of nix is now tested in normal Buildkite since #3200  ### Issue Number None.  Co-authored-by: Óscar Nájera <[email protected]> Co-authored-by: Johannes Lund <[email protected]>

Anviking self-assigned this Mar 3, 2022

Anviking force-pushed the anviking/ADP-1433/node-1.34 branch 5 times, most recently from d245326 to bf59df7 Compare March 6, 2022 20:43

jonathanknowles approved these changes Mar 10, 2022

View reviewed changes

Anviking changed the title ~~Bump cardano-node to 1.34.0~~ Bump cardano-node to 1.34.1 Mar 10, 2022

Anviking force-pushed the anviking/ADP-1433/node-1.34 branch from c32c8d6 to ff002a1 Compare March 15, 2022 12:07

iohk-bors bot added a commit that referenced this pull request Mar 15, 2022

Try #3160:

b295c5a

Anviking force-pushed the anviking/ADP-1433/node-1.34 branch 5 times, most recently from cda63a7 to d6f3af1 Compare March 15, 2022 22:27

iohk-bors bot added a commit that referenced this pull request Mar 16, 2022

Try #3160:

9d4ec37

Anviking commented Mar 16, 2022

View reviewed changes

docs/developers/Building.md Outdated Show resolved Hide resolved

Anviking requested a review from sevanspowell March 16, 2022 15:52

Anviking force-pushed the anviking/ADP-1433/node-1.34 branch from 0589eb9 to 02b5c39 Compare March 16, 2022 16:05

sevanspowell approved these changes Mar 16, 2022

View reviewed changes

Bump cardano-node to 1.34.1

5067134

Anviking and others added 4 commits March 17, 2022 16:52

Remove support for stack build

aabc226

Regenerate nix

bd44fa1

Workaround for haskell.nix issue

80303f8

- Workaround haskell.nix issue (input-output-hk/haskell.nix#1402) by using an earlier version of haskell.nix.

Provide instructions for running the integration tests

2de4ca9

Anviking force-pushed the anviking/ADP-1433/node-1.34 branch from 14535d6 to 2de4ca9 Compare March 17, 2022 16:00

Anviking mentioned this pull request Mar 17, 2022

Revert "Cardano.Wallet.Shelley.Launch.BlockfrostSpec" #3180

Closed

Temporarily mark two failing CLI tests pending

2504194

iohk-bors bot merged commit 0491924 into master Mar 17, 2022

iohk-bors bot deleted the anviking/ADP-1433/node-1.34 branch March 17, 2022 21:57

WilliamKingNoel-Bot pushed a commit that referenced this pull request Mar 17, 2022

docs: Merge #3160

7130c7d

kk-hainq mentioned this pull request Mar 19, 2022

Update cardano-node version to 1.34 IntersectMBO/plutus-apps#356

Closed

This was referenced Apr 8, 2022

Ensure 1.34.1 node bump is reflected in cabal.project #3229

Merged

Update git commit dependency for cardano-node 1.34.1 on cabal.project #3225

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump cardano-node to 1.34.1 #3160

Bump cardano-node to 1.34.1 #3160

Anviking commented Mar 3, 2022 •

edited

Loading

jonathanknowles left a comment •

edited

Loading

Anviking commented Mar 15, 2022

iohk-bors bot commented Mar 15, 2022

Anviking commented Mar 16, 2022

iohk-bors bot commented Mar 16, 2022

sevanspowell left a comment

Anviking commented Mar 17, 2022

iohk-bors bot commented Mar 17, 2022 •

edited by Anviking

Loading

Anviking commented Mar 17, 2022

Anviking commented Mar 17, 2022

iohk-bors bot commented Mar 17, 2022 •

edited by Anviking

Loading

Anviking commented Mar 17, 2022

iohk-bors bot commented Mar 17, 2022

Bump cardano-node to 1.34.1 #3160

Bump cardano-node to 1.34.1 #3160

Conversation

Anviking commented Mar 3, 2022 • edited Loading

Comments

Issue Number

jonathanknowles left a comment • edited Loading

Choose a reason for hiding this comment

Anviking commented Mar 15, 2022

iohk-bors bot commented Mar 15, 2022

try

Anviking commented Mar 16, 2022

iohk-bors bot commented Mar 16, 2022

try

sevanspowell left a comment

Choose a reason for hiding this comment

Anviking commented Mar 17, 2022

iohk-bors bot commented Mar 17, 2022 • edited by Anviking Loading

Anviking commented Mar 17, 2022

Anviking commented Mar 17, 2022

iohk-bors bot commented Mar 17, 2022 • edited by Anviking Loading

Anviking commented Mar 17, 2022

iohk-bors bot commented Mar 17, 2022

Anviking commented Mar 3, 2022 •

edited

Loading

jonathanknowles left a comment •

edited

Loading

iohk-bors bot commented Mar 17, 2022 •

edited by Anviking

Loading

iohk-bors bot commented Mar 17, 2022 •

edited by Anviking

Loading