Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl signing for minting/burning in new tx flow #3199

Merged
merged 29 commits into from
Mar 31, 2022
Merged

Impl signing for minting/burning in new tx flow #3199

merged 29 commits into from
Mar 31, 2022

Commits on Mar 29, 2022

  1. clean not needed bits - only new tx flow support minting/burning

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    65a8470 View commit details
    Browse the repository at this point in the history

  2. add ApiPostPolicyKeyData

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    a1aae13 View commit details
    Browse the repository at this point in the history

  3. ApiPostPolicyKeyData - part 2

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    01967e1 View commit details
    Browse the repository at this point in the history

  4. add writePolicyKey in Cardano.Wallet

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    86020ae View commit details
    Browse the repository at this point in the history

  5. conclude postPolicyKey endpoint

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    1bb0286 View commit details
    Browse the repository at this point in the history

  6. add signing for minting/burning

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    81b2d5f View commit details
    Browse the repository at this point in the history

  7. extend integration test - part 1

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    35e65ff View commit details
    Browse the repository at this point in the history

  8. fix fee calculation

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    7fbd3f3 View commit details
    Browse the repository at this point in the history

  9. reorganize integration tests for better reuse

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    00edc09 View commit details
    Browse the repository at this point in the history

  10. prove that minted assets are in wallet finally

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    9251e50 View commit details
    Browse the repository at this point in the history

  11. prove burning in integration testing

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    5eecd0d View commit details
    Browse the repository at this point in the history

  12. postPolicyPublicKey with optional param plus cleaning

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    e44cb74 View commit details
    Browse the repository at this point in the history

  13. unify mint/burn response for construct/decode - swagger

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    2c8dadd View commit details
    Browse the repository at this point in the history

  14. finish refactoring construct/decode

    @paweljakubas
    paweljakubas committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    f43122f View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Wrap long lines according to team coding standard. 

    https://input-output-hk.github.io/adrestia/code/Coding-Standards#limit-line-length-to-80-characters
    @jonathanknowles
    jonathanknowles committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    7f961eb View commit details
    Browse the repository at this point in the history

  2. Use just a single blank line between definitions. 

    https://input-output-hk.github.io/adrestia/code/Coding-Standards#use-only-a-single-blank-line-between-top-level-definitions
    @jonathanknowles
    jonathanknowles committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    fba7aae View commit details
    Browse the repository at this point in the history

  3. Use 4-space indents in Haskell source files. 

    See `.editorconfig`.
    @jonathanknowles
    jonathanknowles committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    9b0520c View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Add type signatures to helper functions in TransactionsNew.

    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    fead6f8 View commit details
    Browse the repository at this point in the history

  2. Rename mintAssetCheck to mintAssetsCheck. 

    This is for consistency with its sister function `burnAssetsCheck`.
    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    2626b0b View commit details
    Browse the repository at this point in the history

  3. Rename ApiTokenAsset to ApiTokenAmountFingerprint. 

    After review discussion.
    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    6951314 View commit details
    Browse the repository at this point in the history

  4. Simplify applicative expressions. 

    (Remove redundant `<$> pure` combinations.)
    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    cded02d View commit details
    Browse the repository at this point in the history

  5. Use GeneralizedNewtypeDeriving to eliminate boilerplate.

    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    ba75be5 View commit details
    Browse the repository at this point in the history

  6. Rename numberOfAssets to tokenAmount. 

    This is consistent with the `ApiTokenAmountFingerprint` name.
    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    66bccd7 View commit details
    Browse the repository at this point in the history

  7. Revise error message for MissingPolicyPublicKey.

    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    2a92320 View commit details
    Browse the repository at this point in the history

  8. Add note regarding the use of L.nub. 

    See review conversation here:

#3199 (comment)
    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    9049901 View commit details
    Browse the repository at this point in the history

  9. Add TODO that links to ADP-1193 in TRANS_NEW_CREATE_10e.

    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    230d8c1 View commit details
    Browse the repository at this point in the history

  10. Replace const x <$> with x <$ in Api.Server.

    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    8c03c46 View commit details
    Browse the repository at this point in the history

  11. Remove redundant parentheses and do usages.

    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    7076da5 View commit details
    Browse the repository at this point in the history

  12. Remove redundant check for empty TokenMap in toApiTokens.

    @jonathanknowles
    jonathanknowles committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    1c4da7c View commit details
    Browse the repository at this point in the history