Get node db from aws in Windows e2e flow #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
force-pushed
the
piotr/adp-1550/cache-node-db-from-web
branch
from
827418d
to
bf1c4bd
Compare
piotr-iohk
force-pushed
the
piotr/adp-1550/cache-node-db-from-web
branch
from
1ed1289
to
eeb7123
Compare
piotr-iohk
force-pushed
the
piotr/adp-1550/cache-node-db-from-web
branch
2 times, most recently
from
b9f3f01
to
809d5b3
Compare
piotr-iohk
force-pushed
the
piotr/adp-1550/cache-node-db-from-web
branch
16 times, most recently
from
b2b5b5f
to
42c1415
Compare
piotr-iohk
force-pushed
the
piotr/adp-1550/cache-node-db-from-web
branch
from
42c1415
to
c3ce02b
Compare
HeinrichApfelmus
approved these changes
Apr 6, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
I have introduced an option to get Node DB from cache from AWS snapshot provided by @jbgi ❤️ .
For now Linux, MacOS and Docker flows remain on GH actions cache, Windows has been put on AWS. That's because GH actions is slightly faster and AWS snapshots will always probably be compatible with currently released node version and that's not always what the wallet wants. In any case it can be easily switched from one to another.
During the course I've found out that the reason Windows machines where getting out of disk space was due to the fact that by default they store things on D:\ which has ~12GB space only. Those GH Windows' have also C:\ which has ~100GB. I've changes Windows flow to use C:\ instead. (It is not an issue for Linux and Mac because they just work in the context of
/)Issue Number
ADP-1550