Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests / pending test against ADP-1738 #3267

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented May 4, 2022

Comments

Pending integration test TRANS_NEW_CREATE_MINT_SCRIPTS for ADP-1738
Screenshot from 2022-05-06 13-17-16

Issue Number

ADP-1738, ADP-1193

Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😊

I was wondering whether runResourceT should be called only once in first line (starting with describe …) rather be called again and again for each scenario, but I believe that the latter approach is perfectly fine.

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request May 6, 2022
3267: Update tests / pending test against ADP-1738 r=piotr-iohk a=piotr-iohk

- 58dbe4a
  Adjust e2e tests after API changes from #3249
  
- 71969cb
  Pending integration tests against ADP-1738


### Comments
Pending integration test `TRANS_NEW_CREATE_MINT_SCRIPTS` for ADP-1738
![Screenshot from 2022-05-06 13-17-16](https://user-images.githubusercontent.com/42900201/167121713-6af508af-5670-4515-9ce7-37c42eaf04dd.png)


### Issue Number

ADP-1738, ADP-1193


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 6, 2022

Build failed:

#Hydra timeout

@piotr-iohk
Copy link
Contributor Author

bors merge

iohk-bors bot added a commit that referenced this pull request May 6, 2022
3267: Update tests / pending test against ADP-1738 r=piotr-iohk a=piotr-iohk

- 58dbe4a
  Adjust e2e tests after API changes from #3249
  
- 71969cb
  Pending integration tests against ADP-1738


### Comments
Pending integration test `TRANS_NEW_CREATE_MINT_SCRIPTS` for ADP-1738
![Screenshot from 2022-05-06 13-17-16](https://user-images.githubusercontent.com/42900201/167121713-6af508af-5670-4515-9ce7-37c42eaf04dd.png)


### Issue Number

ADP-1738, ADP-1193


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 6, 2022

Timed out.

@piotr-iohk
Copy link
Contributor Author

bors merge

iohk-bors bot added a commit that referenced this pull request May 6, 2022
3267: Update tests / pending test against ADP-1738 r=piotr-iohk a=piotr-iohk

- 58dbe4a
  Adjust e2e tests after API changes from #3249
  
- 71969cb
  Pending integration tests against ADP-1738


### Comments
Pending integration test `TRANS_NEW_CREATE_MINT_SCRIPTS` for ADP-1738
![Screenshot from 2022-05-06 13-17-16](https://user-images.githubusercontent.com/42900201/167121713-6af508af-5670-4515-9ce7-37c42eaf04dd.png)


### Issue Number

ADP-1738, ADP-1193


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 6, 2022

Build failed:

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 9, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit e8eb748 into master May 9, 2022
@iohk-bors iohk-bors bot deleted the piotr/update-tests branch May 9, 2022 07:04
WilliamKingNoel-Bot pushed a commit that referenced this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants