Light mode: reduce concurrency when retrieving data. #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
approved these changes
Jun 17, 2022
Co-authored-by: Heinrich Apfelmus <[email protected]>
Co-authored-by: Heinrich Apfelmus <[email protected]>
Unisay
force-pushed
the
yura/ADP-1651/fixes-optimisations
branch
from
224d903
to
c205888
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 20, 2022
3340: Update to cardano-node 1.35-rc3 r=Anviking a=sevanspowell I have: - Bumped the following dependencies to the `1.35.0-rc3` tag: - cardano-node - cardano-base - cardano-ledger - ouroboros-network - Updated cardano-wallet code to build with `1.35.0-rc3` tag: - `evaluateTransactionExecutionUnits` has a new error type, updated `ErrAssignRedeemers` accordingly. - `SimpleScriptWitness` now takes a `SimpleScriptOrReferenceInput` instead of a `SimpleScript`, updated generators accordingly. TODO: - [x] Consider whether the `prop_balanceTransactionUnresolvedInputs` test makes sense anymore. - [ ] Test the API output of `ErrAssignRedeemersTranslationError`. - [x] Update readme compatibility matrix ### Issue Number ADP-1907 3341: Light mode: reduce concurrency when retrieving data. r=Unisay a=Unisay - [x] Replace concurrent traversals with sequential ones in order to minimize likelihood of hitting `Too Many Requests` error. - [x] Fix bug with fetching Tx hashes for the same block multiple times. ### Comments Unfortunately the "Too Many Requests" error shows up anyway: [wallet.log](https://github.com/input-output-hk/cardano-wallet/files/8918830/wallet.log) ### Issue Number ADP-1651 Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Yuriy Lazaryev <[email protected]> Co-authored-by: Yura Lazarev <[email protected]>
|
Build failed (retrying...): |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 20, 2022
3341: Light mode: reduce concurrency when retrieving data. r=Unisay a=Unisay - [x] Replace concurrent traversals with sequential ones in order to minimize likelihood of hitting `Too Many Requests` error. - [x] Fix bug with fetching Tx hashes for the same block multiple times. ### Comments Unfortunately the "Too Many Requests" error shows up anyway: [wallet.log](https://github.com/input-output-hk/cardano-wallet/files/8918830/wallet.log) ### Issue Number ADP-1651 Co-authored-by: Yuriy Lazaryev <[email protected]> Co-authored-by: Yura Lazarev <[email protected]>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 20, 2022
3341: Light mode: reduce concurrency when retrieving data. r=Unisay a=Unisay - [x] Replace concurrent traversals with sequential ones in order to minimize likelihood of hitting `Too Many Requests` error. - [x] Fix bug with fetching Tx hashes for the same block multiple times. ### Comments Unfortunately the "Too Many Requests" error shows up anyway: [wallet.log](https://github.com/input-output-hk/cardano-wallet/files/8918830/wallet.log) ### Issue Number ADP-1651 Co-authored-by: Yuriy Lazaryev <[email protected]> Co-authored-by: Yura Lazarev <[email protected]>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 20, 2022
3340: Update to cardano-node 1.35-rc3 r=Anviking a=sevanspowell I have: - Bumped the following dependencies to the `1.35.0-rc3` tag: - cardano-node - cardano-base - cardano-ledger - ouroboros-network - Updated cardano-wallet code to build with `1.35.0-rc3` tag: - `evaluateTransactionExecutionUnits` has a new error type, updated `ErrAssignRedeemers` accordingly. - `SimpleScriptWitness` now takes a `SimpleScriptOrReferenceInput` instead of a `SimpleScript`, updated generators accordingly. TODO: - [x] Consider whether the `prop_balanceTransactionUnresolvedInputs` test makes sense anymore. - [ ] Test the API output of `ErrAssignRedeemersTranslationError`. - [x] Update readme compatibility matrix ### Issue Number ADP-1907 3341: Light mode: reduce concurrency when retrieving data. r=Unisay a=Unisay - [x] Replace concurrent traversals with sequential ones in order to minimize likelihood of hitting `Too Many Requests` error. - [x] Fix bug with fetching Tx hashes for the same block multiple times. ### Comments Unfortunately the "Too Many Requests" error shows up anyway: [wallet.log](https://github.com/input-output-hk/cardano-wallet/files/8918830/wallet.log) ### Issue Number ADP-1651 3344: Move `adjustNoSuchWallet` and `ErrNoSuchWallet` r=HeinrichApfelmus a=HeinrichApfelmus ### Issue number ADP-1043 ### Overview This pull request is a pure refactoring. We move `adjustNoSuchWallet` and `ErrNoSuchWallet` to the `Cardano.Wallet.DB.WalletState` module. Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Yuriy Lazaryev <[email protected]> Co-authored-by: Yura Lazarev <[email protected]> Co-authored-by: Heinrich Apfelmus <[email protected]>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too Many Requestserror.Comments
Unfortunately the "Too Many Requests" error shows up anyway:
wallet.log
Issue Number
ADP-1651