Add checkpointPolicy field to ChainFollower
#3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… currently equal to `sparseArithmetic`.
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-1043/chainfollower-with-policy
branch
from
5570557
to
8f6aacb
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-1043/chainfollower-with-policy
branch
from
8f6aacb
to
2fa97e9
Compare
Unisay
reviewed
Jul 1, 2022
Unisay
approved these changes
Jul 1, 2022
Co-authored-by: Yura Lazarev <[email protected]>
|
bors merge |
|
Build succeeded: |
iohk-bors
bot
deleted the
HeinrichApfelmus/ADP-1043/chainfollower-with-policy
branch
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number
ADP-1497
Overview
In this pull request, we add a
checkpointPolicyfield to theChainFollowertype.This policy enables any chain synchronizer which does not retrieve full blocks — such as
lightSync— to target those block heights at which the follower makes checkpoints.ℹ️ This pull request only changes the
ChainFollowertype — incorporating this new information into thelightSyncalgorithm is left for a future pull request.Details
defaultPolicytoCardano.Wallet.Checkpointsin order to reduce cognitive burden in the places where aChainFolloweris constructed.Comments
lightSyncalgorithm before merging Simplify checkpoint creation and pruning, take 2 #3369 — otherwise, no good checkpoints will be created in light-mode. That said, light-mode may be so fast that it can work without checkpoints.