Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min_utxo_value + lovelace_per_utxo check from minting to foreign wallet test #3390

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Jul 14, 2022

  • Remove min_utxo_value + lovelace_per_utxo check from minting to foreign wallet test

Comments

This test failed after #3368 was merged. Since the min UTxO value is a function of the size of the TxOut, rather than a constant value it is rather unpredictable to calculate this by hand (outside of wallet) especially for the wallets on the testnet which utxo may change between the runs. Removing this check then.

Issue Number

n/a

@piotr-iohk piotr-iohk self-assigned this Jul 14, 2022
# therefore the cost is fee + mintUTxOValue of ADA that is required
# for transfering the assets over the network
# in this the total `cost` is pure ADA minUTxOValue + 11 'utxo words' + fee
min_utxo_value = NETWORK.parameters['minimum_utxo_value']['quantity'].to_i
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @piotr-iohk

Just wondering: is it possible to hard-code the expected minimum UTxO value(s) in the test?

This might give us a sanity check that the values are reasonable. 🤔

If the minimum UTxO value does change in any way (in future), then:

  • it would cause this test to fail;
  • we would have a chance to see the new value;
  • we would have a chance to verify that it looks reasonable (i.e., to repeat the sanity check).

Alternatively, if it's too difficult, then I think deleting this is fair enough.

Copy link
Contributor Author

@piotr-iohk piotr-iohk Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, actually at this moment is passes with this (i.e. with what GET network/parameters shows)... it failed last night, so I assume that it was due to the fact that there was different number/size of TxOut in the transaction than usual (since the utxo was probably differently shaped). The wallet is out there on the testnet and it runs through ~200 tests every night, it is rather hard to keep the utxo under control.

So in other words, if minUtxOValue depends on the number of outputs in a transaction it is rather hard to come up with a value to hardcode it. (At least I don't have idea how).

@jonathanknowles jonathanknowles self-requested a review July 15, 2022 09:48
@piotr-iohk piotr-iohk merged commit ddc52e2 into master Jul 15, 2022
@piotr-iohk piotr-iohk deleted the piotr/mint_to_foreign_wallet_e2e_test_failing branch July 15, 2022 13:49
WilliamKingNoel-Bot pushed a commit that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants