Use cardano-ledger for all minimum UTxO calculations
#3456
Commits on Aug 25, 2022
-
-
Add function
computeMinimumCoinForUTxOCardanoApi.This function simply encapsulates the Cardano API minimum UTxO function in a wallet-friendly interface, acceping and returning wallet-friendly types.
-
Make
unsafeCoinFromCardanoApiCalculateMinimumUTxOResultan inner fu……nction. This function is now only used by `computeMinimumCoinForUTxOCardanoApi`. We can safely make it an inner function.
-
Add function
computeMinimumCoinForUTxOCardanoLedger.This function simply encapsulates the Cardano Ledger minimum UTxO function in a wallet-friendly interface, acceping and returning wallet-friendly types.
-
Test that
computeMinimumCoinForUTxO{CardanoApi,CardanoLedger}are e……quivalent. We eventually wish to switch from the Cardano API implementation of the minimum UTXO calculaion to the Cardano Ledger implementation. But before we do that, we test that the implementations are equivalent.
-
Use
computeMinimumCoinForUTxOCardanoLedgerin implementation.This commit switches from the Cardano API implementation of the minimum UTxO calculation to the Cardano Ledger implementation.
-
Do not treat the Babbage era specially in the public implementation.
Now that we are using the Cardano Ledger implementation of the minimum UTxO calculation, we no longer need to treat the Babbage era specially in our public implementation.
-
-
-
Delete redundant code from public
MinimumUTxOmodule.These functions are no longer used.
-
Remove
prop_computeMinimumCoinForUTxO_evaluation.Since our minimum UTxO calculation now relies on Cardano Ledger, we no longer need to convert from era-specific protocol parameters to the era-agnostic protocol parameters required by the Cardano API. Therefore, this property test (which checked that conversions would never cause run-time errors) is no longer necessary.
-
Use underscores to make function names clearer.
The juxtaposition of "UTxO" followed by another capitalised word is rather hard to read. This commit introduces underscores to aid readability.
-
-
Adjust signature of `prop_computeMinimumCoinForUTxO_CardanoApi_Cardan…
…oLedger`. It's simpler for this property to accept a `TokenBundle` instead of a `TokenMap` and `Coin`. The `Arbitrary` instance for `TokenBundle` uses the `genTxOutTokenBundle` generator, which already has good coverage of minimum and maximum values specifically in the context of a transaction output. This allows us to get rid of the `Arbitrary` instance for `Coin` (which in hindsight would have been better to implement with the `genTxOutCoin` generator). In response to review feedback: #3456 (comment)
-
Simplify type signatures of
to{Alonzo,Babbage}TxOut.We can use the `Standard{Alonzo,Babbage}` synonyms for greater concision.
