Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3173] Enable aarch64-darwin #4259

Merged
merged 3 commits into from
Jan 31, 2024
Merged

[ADP-3173] Enable aarch64-darwin #4259

merged 3 commits into from
Jan 31, 2024

Conversation

HeinrichApfelmus
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus commented Nov 22, 2023 •
edited
Loading

This pull request builds cardano-wallet for the aarch64-darwin architecture.

  • Enables unit tests for aarch64-darwin
  • Builds a release package for aarch64-darwin

Comments

cardano-node-8.7.3 officially supports aarch64-darwin

Changelog

Removed

  • The legacy scrypt passphrase scheme is no longer supported on aarch64-darwin builds.

Issue Number

ADP-3173

@HeinrichApfelmus HeinrichApfelmus self-assigned this Nov 22, 2023
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3173/nix-aarch64-darwin branch 2 times, most recently from f4a6bd3 to 81530b0 Compare November 27, 2023 16:32
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3173/nix-aarch64-darwin branch from 81530b0 to a0c44dd Compare January 8, 2024 12:47
@HeinrichApfelmus
Copy link
Contributor Author

Linker errors — perhaps Daedalus has found a way to resolve them? See comment in #4095

@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3173/nix-aarch64-darwin branch from a0c44dd to 5a36ed4 Compare January 29, 2024 14:01
@HeinrichApfelmus HeinrichApfelmus force-pushed the HeinrichApfelmus/ADP-3173/nix-aarch64-darwin branch from 4f33175 to d9a8286 Compare January 31, 2024 10:31
@HeinrichApfelmus HeinrichApfelmus changed the title [ADP-3173] Enable unit tests on aarch64-darwin [ADP-3173] Enable aarch64-darwin Jan 31, 2024
@HeinrichApfelmus
Copy link
Contributor Author

Everything works as expected:

arm64 artifacts

@HeinrichApfelmus HeinrichApfelmus marked this pull request as ready for review January 31, 2024 11:00
Anviking
Anviking approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@HeinrichApfelmus HeinrichApfelmus added this pull request to the merge queue Jan 31, 2024
Merged via the queue into master with commit 872f068 Jan 31, 2024
3 checks passed
@HeinrichApfelmus HeinrichApfelmus deleted the HeinrichApfelmus/ADP-3173/nix-aarch64-darwin branch January 31, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Anviking approved these changes

Assignees

@HeinrichApfelmus HeinrichApfelmus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeinrichApfelmus @Anviking