Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3224] Fix bash instructions to start node and wallet containers in README #4364

Merged
merged 1 commit into from
Dec 20, 2023
Merged

[ADP-3224] Fix bash instructions to start node and wallet containers in README #4364

merged 1 commit into from
Dec 20, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Dec 19, 2023

  • Fix broken docker instructions in README

ADP-3224

@paolino paolino self-assigned this Dec 19, 2023
paweljakubas
paweljakubas approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Anviking
Anviking approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not run the whole thing, but lgtm

README.md Show resolved Hide resolved
@paolino paolino added this pull request to the merge queue Dec 20, 2023
Merged via the queue into master with commit b37431b Dec 20, 2023
3 checks passed
@paolino paolino deleted the paolino/ADP-3224/fix-instructions-in-README branch December 20, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@Anviking Anviking Anviking approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolino @Anviking @paweljakubas