[ADP-3286] Remove scrypt build dependency and flag
#4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
approved these changes
Feb 16, 2024
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3286/remove-scrypt
branch
from
e4d771c
to
a726be9
Compare
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
…is pull request finally removes the build dependency on the [scrypt][] package, which was last uploaded in 2014. [scrypt]: https://hackage.haskell.org/package/scrypt ### Comments CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project configs default.nix docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml hie.yaml justfile lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Switching from `scrypt` to `cryptonite` with tests was done in #4449 . CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project configs default.nix docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml hie.yaml justfile lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Unrelatedly, it appears that the source repository of the [cryptonite] package has been archived by Vincent. It appears [crypton] is a blessed fork. [cryptonite]: https://github.com/haskell-crypto/cryptonite [crypton]: https://github.com/kazu-yamamoto/crypton ### Issue number ADP-3286 Source commit: 6d3d9d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request finally removes the build dependency on the scrypt package, which was last uploaded in 2014.
Comments
scrypttocryptonitewith tests was done in [ADP-3286] Support verificationEncryptWithScryptusingcryptonite#4449 .Issue number
ADP-3286