Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "certificate" tests in Conway #4454

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Feb 19, 2024

  • Enable delegation tests for Conway
  • Ensure Conway delegation works by adding missing txDeposit-related glue

Comments

LOCAL_CLUSTER_CONFIGS=../local-cluster/test/data/cluster-configs CARDANO_WALLET_TEST_DATA=test/data LOCAL_CLUSTER_ERA=conway cabal test cardano-wallet:integration --test-options '--match JOIN_01 -j 4'

Issue Number

Related to ADP-3212, #4438

@Anviking Anviking assigned Anviking and unassigned Anviking Feb 19, 2024
@Anviking Anviking force-pushed the anviking/conway-delegation-tests branch from fecc201 to d6a69e4 Compare February 19, 2024 15:51
@Anviking Anviking force-pushed the anviking/conway-delegation-tests branch from d6a69e4 to 1566e7c Compare February 20, 2024 11:33
@Anviking Anviking self-assigned this Feb 21, 2024
@Anviking Anviking force-pushed the anviking/conway-delegation-tests branch from 1566e7c to f0a79f4 Compare February 21, 2024 10:27
@Anviking Anviking marked this pull request as ready for review February 21, 2024 10:39
@@ -306,7 +306,7 @@ withinEra = (>=) `on` numberEra

-- | Deserialise a transaction to construct a 'SealedTx'.
sealedTxFromBytes :: ByteString -> Either DecoderError SealedTx
sealedTxFromBytes = sealedTxFromBytes' (anyCardanoEra BabbageEra)
sealedTxFromBytes = sealedTxFromBytes' maxBound
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆

@Anviking Anviking force-pushed the anviking/conway-delegation-tests branch 4 times, most recently from 48f9be3 to 7fe49df Compare February 21, 2024 12:01
@@ -2094,6 +2094,7 @@ selectCoins ctx@ApiLayer {..} argGenChange (ApiT walletId) body = do
let txCtx = defaultTransactionCtx
{ txWithdrawal = withdrawal
, txMetadata = getApiT <$> body ^. #metadata
, txDeposit = Just $ W.getStakeKeyDeposit pp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Anviking Anviking added this pull request to the merge queue Feb 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2024
@Anviking Anviking added this pull request to the merge queue Feb 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2024
@Anviking Anviking force-pushed the anviking/conway-delegation-tests branch 3 times, most recently from 2b2794a to ececc4b Compare February 21, 2024 23:31
@Anviking Anviking force-pushed the anviking/conway-delegation-tests branch from bb12c87 to f67423c Compare February 22, 2024 16:34
On another branch I found the rewards paid out to be insanely huge.

The rewards pot each epoch is given by:
  min(η, 1)ρ (T∞ − T)
. With ρ at 0.17 it would seem the treasury might quickly be exhausted.

Tweak \rho again to fix `TRANS_NEW_JOIN_01a`
To avoid this integration test expectation failure:

```
  framework/Test/Integration/Framework/DSL.hs:1412:11:
  10) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_LIST_01 - List stake pools, contains and is sorted by non-myopic-rewards
       Quantity 23761378428107 does not satisfy (> Quantity 23761378428107)
       Waited longer than 90s to resolve action: "eventually shows non-zero rewards".
```
@Anviking Anviking force-pushed the anviking/conway-delegation-tests branch from cec5933 to 8ec3b4c Compare February 22, 2024 21:06
@Anviking Anviking added this pull request to the merge queue Feb 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 22, 2024
@Anviking Anviking added this pull request to the merge queue Feb 23, 2024
Merged via the queue into master with commit d14ec60 Feb 23, 2024
3 checks passed
@Anviking Anviking deleted the anviking/conway-delegation-tests branch February 23, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants