-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable "certificate"
tests in Conway
#4454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/conway-delegation-tests
branch
from
February 19, 2024 15:51
fecc201
to
d6a69e4
Compare
Anviking
commented
Feb 20, 2024
lib/wallet/integration/scenarios/Test/Integration/Scenario/API/Shelley/StakePools.hs
Outdated
Show resolved
Hide resolved
Anviking
force-pushed
the
anviking/conway-delegation-tests
branch
from
February 20, 2024 11:33
d6a69e4
to
1566e7c
Compare
Anviking
force-pushed
the
anviking/conway-delegation-tests
branch
from
February 21, 2024 10:27
1566e7c
to
f0a79f4
Compare
Anviking
commented
Feb 21, 2024
@@ -306,7 +306,7 @@ withinEra = (>=) `on` numberEra | |||
|
|||
-- | Deserialise a transaction to construct a 'SealedTx'. | |||
sealedTxFromBytes :: ByteString -> Either DecoderError SealedTx | |||
sealedTxFromBytes = sealedTxFromBytes' (anyCardanoEra BabbageEra) | |||
sealedTxFromBytes = sealedTxFromBytes' maxBound |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👆
Anviking
commented
Feb 21, 2024
lib/integration/scenarios/Test/Integration/Scenario/API/Shelley/StakePools.hs
Outdated
Show resolved
Hide resolved
Anviking
force-pushed
the
anviking/conway-delegation-tests
branch
4 times, most recently
from
February 21, 2024 12:01
48f9be3
to
7fe49df
Compare
@@ -2094,6 +2094,7 @@ selectCoins ctx@ApiLayer {..} argGenChange (ApiT walletId) body = do | |||
let txCtx = defaultTransactionCtx | |||
{ txWithdrawal = withdrawal | |||
, txMetadata = getApiT <$> body ^. #metadata | |||
, txDeposit = Just $ W.getStakeKeyDeposit pp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
paweljakubas
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 21, 2024
Anviking
force-pushed
the
anviking/conway-delegation-tests
branch
3 times, most recently
from
February 21, 2024 23:31
2b2794a
to
ececc4b
Compare
Anviking
force-pushed
the
anviking/conway-delegation-tests
branch
from
February 22, 2024 16:34
bb12c87
to
f67423c
Compare
On another branch I found the rewards paid out to be insanely huge. The rewards pot each epoch is given by: min(η, 1)ρ (T∞ − T) . With ρ at 0.17 it would seem the treasury might quickly be exhausted. Tweak \rho again to fix `TRANS_NEW_JOIN_01a`
To avoid this integration test expectation failure: ``` framework/Test/Integration/Framework/DSL.hs:1412:11: 10) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_LIST_01 - List stake pools, contains and is sorted by non-myopic-rewards Quantity 23761378428107 does not satisfy (> Quantity 23761378428107) Waited longer than 90s to resolve action: "eventually shows non-zero rewards". ```
Anviking
force-pushed
the
anviking/conway-delegation-tests
branch
from
February 22, 2024 21:06
cec5933
to
8ec3b4c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
Issue Number
Related to ADP-3212, #4438