Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive {To,From}JSON instances for ApiEncryptMetadata. #4588

Merged
merged 6 commits into from
May 14, 2024
Merged

Derive {To,From}JSON instances for ApiEncryptMetadata. #4588

merged 6 commits into from
May 14, 2024

Conversation

jonathanknowles
Copy link
Member

This PR:

  • derives {To,From}JSON instances for all the constituent parts of ApiEncryptMetadata.
  • adds JSON roundtrip and golden tests for the ApiEncryptMetadata type.

Issue

ADP-322

@jonathanknowles jonathanknowles self-assigned this May 14, 2024
@jonathanknowles jonathanknowles mentioned this pull request May 14, 2024
Merged
9 tasks
paweljakubas
paweljakubas approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed! it can be automatically generated rather than done by hand 🥇

@paweljakubas paweljakubas merged commit 5d55509 into paweljakubas/adp-322/add-metadata-encryption-to-api May 14, 2024
2 of 3 checks passed
@paweljakubas paweljakubas deleted the jonathanknowles/adp-322/simplify-api-encrypt-metadata-method branch May 14, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@jonathanknowles jonathanknowles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanknowles @paweljakubas