Replace deprecated evaluateTransactionFee with getMinFeeTx
#4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
commented
Jun 14, 2024
Anviking
commented
Jun 14, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
- Add `getUTxOByTxIn` local state query - Resolve `PartialTx` inputs over LSQ in `Cardano.Wallet.balanceTx` ### Comments This is part of the fix for the [integration test in the 8.11 branch](https://buildkite.com/cardano-foundation/cardano-wallet/builds/5254#018fee3c-01ad-441e-bb7e-25acd78cb7f3); if we have the UTxO of the reference input containing the script used for minting in constructTx, then `Ledger.getMinFeeTxUtxo pp tx utxo` will correctly account for minFeeRefScriptCoinsPerByte * totalRefScriptSize. Previous step: #4629 Next step: #4631 ### Issue Number ADP-3373
Anviking
force-pushed
the
anviking/ADP-3334/getMinFeeTx
branch
2 times, most recently
from
efe8ef5
to
88f74f3
Compare
Anviking
force-pushed
the
anviking/ADP-3334/getMinFeeTx
branch
from
88f74f3
to
6a01cc2
Compare
With the 8.11 node the deprecated `evaluateTransactionFee` is removed, and additionally, we will need to adapt to changes to the calculation present in `getMinFeeTxUtxo`.
Anviking
force-pushed
the
anviking/ADP-3334/getMinFeeTx
branch
from
6a01cc2
to
5802258
Compare
| @@ -16,10 +15,6 @@ | |||
| {-# LANGUAGE UndecidableInstances #-} | |||
| {-# LANGUAGE UndecidableSuperClasses #-} | |||
|
|
|||
| {-# OPTIONS_GHC -Wno-warnings-deprecations #-} | |||
| -- For 'Shelley.evaluateTransactionFee', see ADP-3334 | |||
paweljakubas
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizeOf_BootstrapWitnesses)Comments
Issue Number
ADP-3334