Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review deployment script to include both jormungandr and http-bridge #503

Merged
merged 5 commits into from
Jul 4, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Jul 3, 2019

Issue Number

#357

Overview

  • I have adjusted the deployment scripts to also deploy an executable for jormungandr
  • I added a travis_retry pragma when doing git push to gh-pages as I noticed this one sometimes fail (the push is rather big, and sometimes github timeouts it seems...), retrying shortly after does work it seems.
  • I added an extra stack clean to re-compile the binaries properly without --fast which caused optimizations to be turned off otherwise (-O0).
  • I have wrapped the binaries into tar.gz archives. This has two benefits:
    • We can rename both binaries to cardano-wallet such that it's less annoying to use. Users just pick the archives they're interested in.
    • If we export raw binaries to Github, the executable permissions are removed on the files which forces users to chmod +x after downloading the files. Putting them in an archive doesn't remove the initial file permission.

Comments

@KtorZ KtorZ requested a review from rvl July 3, 2019 15:51
@KtorZ KtorZ self-assigned this Jul 3, 2019
KtorZ added 3 commits July 4, 2019 09:25
Unfortunately, we can't do that as stack erases coverage data between each run. So, after all tests
have run, we only get coverage results for the last suite
@KtorZ KtorZ force-pushed the KtorZ/deploy-jormungandr branch from 4e0e5ff to 437c7e6 Compare July 4, 2019 07:29
@KtorZ KtorZ merged commit 01b5de7 into master Jul 4, 2019
@KtorZ KtorZ deleted the KtorZ/deploy-jormungandr branch July 4, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants