Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PORT_ tests for Jörmungandr #506

Merged
merged 3 commits into from
Jul 4, 2019
Merged

PORT_ tests for Jörmungandr #506

merged 3 commits into from
Jul 4, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Jul 4, 2019

Issue Number

#358

Overview

  • I have enabled PORT_XXX tests on Jörmungandr

Comments

@KtorZ KtorZ requested a review from piotr-iohk July 4, 2019 09:18
@KtorZ KtorZ self-assigned this Jul 4, 2019
paweljakubas
paweljakubas approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Removed persistent-sqlite from cabal and corresponding nix entries

@paweljakubas paweljakubas merged commit b4b922b into master Jul 4, 2019
@paweljakubas paweljakubas deleted the KtorZ/integration-jormungandr-port branch July 4, 2019 12:36
@KtorZ KtorZ mentioned this pull request Jul 4, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@piotr-iohk piotr-iohk Awaiting requested review from piotr-iohk

Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
Jörmungandr Integration Testing
Development

Successfully merging this pull request may close these issues.
2 participants
@KtorZ @paweljakubas