-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add estimate fee endpoint #507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @paweljakubas !
I haven't look in depth to the integration scenarios. From a quick glance, this looks okay, but I'll spend a bit more time later reviewing carefully and I invite @piotr-iohk to also do the same 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the tests - looking good, thanks a lot @paweljakubas ! :)
There's one test that could be added: estimate transaction for amount = 0
. That one should behave different for http-bridge
and jormungandr
so they should go to their specific libs, like:
}|] | ||
r <- request @ApiFee ctx (postTxFeeEp wSrc) Default payload | ||
verify r | ||
[ expectResponseCode HTTP.status202 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps let's also check the amount here: expectFieldBetween amount...
Issue Number
#469
Overview
Comments