Jormungandr.NetworkSpec: Add more error path tests #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
rvl/460/jm-tests
branch
from
12d8bba
to
431a3c2
Compare
Anviking
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
LGTM!
I replaced the isLeft check with a \case checking for ErrGetDescendantsParentNotFound (431a3c2). I presume this wasn't done since ErrGetDescendants wasn't exported. Since we already export JormungandrLayer I see no reason why we wouldn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #460
Overview
Adds a couple tests abusing the jormungandr node API.