Fix Sqlite DB on Windows #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Oct 25, 2019
lib/core/src/Cardano/DB/Sqlite.hs
Outdated
| ( runMigration, showMigration ) | ||
|
|
||
| -- Replace the "runMigrationSilent" that uses "hSilence" which does not seem to | ||
| -- work on Windows! |
rvl
force-pushed
the
rvl/703/update-haskell-nix
branch
from
7ccc983
to
717f1b5
Compare
rvl
force-pushed
the
rvl/703/fix-sqlite-windows
branch
from
a25ebd8
to
3ab160e
Compare
|
I was looking at fixing this in our fork of persistent and noticed that the recent persistent-2.10.2 release has a new function In It will be easier to keep persistent-* package versions synced if they are all supplied as |
I agree, this was only temporary until I could get proper access for our team. This has been updated and now points to: https://github.com/input-output-hk/persistent/tree/cardano-wallet |
KtorZ
force-pushed
the
rvl/703/fix-sqlite-windows
branch
from
3ab160e
to
526a981
Compare
KtorZ
force-pushed
the
rvl/703/update-haskell-nix
branch
from
717f1b5
to
317a9cc
Compare
KtorZ
force-pushed
the
rvl/703/update-haskell-nix
branch
from
317a9cc
to
e38b407
Compare
rvl
force-pushed
the
rvl/703/update-haskell-nix
branch
2 times, most recently
from
1679e94
to
a5fecf0
Compare
cleverca22
force-pushed
the
rvl/703/update-haskell-nix
branch
from
4534ec2
to
a591209
Compare
disassembler
force-pushed
the
rvl/703/update-haskell-nix
branch
2 times, most recently
from
3c5af93
to
d27da42
Compare
iohk-bors bot
added a commit
that referenced
this pull request
Nov 4, 2019
888: Update Haskell.nix r=KtorZ a=rvl Relates to #703. # Overview - [x] Updates the Haskell.nix version so that we can build for windows again. - [x] Keeps more or less the same structure as before - i.e. no IFD, no niv. I don't want too much change at once. - [x] Does however update nixpkgs from iohk fork of 18.09 → upstream 19.03. - [x] Provides a big bundle of scripts and tests that can be run on Windows. [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-888) [Hercules jobset](https://hercules-ci.com/github/input-output-hk/cardano-wallet) [Link to download Windows testing bundle for PR #888](https://hydra.iohk.io/job/Cardano/cardano-wallet-pr-888/cardano-wallet-jormungandr-win64/latest) [Link to download Windows testing bundle (master branch)](https://hydra.iohk.io/job/Cardano/cardano-wallet/cardano-wallet-jormungandr-win64/latest) # Comments @angerman Please help - [x] Fix failure for missing `hsc2hs` - [x] Fix a previous mistake that affects cross builds (failing to cross-compile bash for some reason) - [x] Worked around an [evaluation error](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-888#tabs-errors) because weeder and ghci are no longer available from `pkgs.haskellPackages`. - [ ] Evaluation is taking a rather long time (5+ hours) in Hydra. - [ ] Some of the Buildkite pipeline steps don't work with the updated Haskell.nix. - [ ] Tests for windows are built not not executed. The tests should be run under wine. # Next PRs - [ ] Fix failures in sqlite tests on Windows ⇒ #918. - [ ] Fix failure in launch command on Windows. - [ ] Fix the UTF-8 text issues on Windows ⇒ #914. - [ ] Add code which tells the windows command prompt to interpret ANSI color codes. - [ ] Identify other test failures and fix. 952: review golden tests for legacy transaction and generate witnesses using jcli r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> N/A # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have reviewed the legacy transaction golden tests, now fully using jcli to also generate the witnesses (this feature was missing when the golden tests were initially implemented). - [x] I have updated the comment on private key to reflect the real format expected by jcli # Comments <!-- Additional comments or screenshots to attach if any --> A bit disappointing to some extend since nothing really has changed.. It seems that we were already providing the right output :( <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Michael Bishop <[email protected]> Co-authored-by: KtorZ <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Nov 4, 2019
888: Update Haskell.nix r=KtorZ a=rvl Relates to #703. # Overview - [x] Updates the Haskell.nix version so that we can build for windows again. - [x] Keeps more or less the same structure as before - i.e. no IFD, no niv. I don't want too much change at once. - [x] Does however update nixpkgs from iohk fork of 18.09 → upstream 19.03. - [x] Provides a big bundle of scripts and tests that can be run on Windows. [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-888) [Hercules jobset](https://hercules-ci.com/github/input-output-hk/cardano-wallet) [Link to download Windows testing bundle for PR #888](https://hydra.iohk.io/job/Cardano/cardano-wallet-pr-888/cardano-wallet-jormungandr-win64/latest) [Link to download Windows testing bundle (master branch)](https://hydra.iohk.io/job/Cardano/cardano-wallet/cardano-wallet-jormungandr-win64/latest) # Comments @angerman Please help - [x] Fix failure for missing `hsc2hs` - [x] Fix a previous mistake that affects cross builds (failing to cross-compile bash for some reason) - [x] Worked around an [evaluation error](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-888#tabs-errors) because weeder and ghci are no longer available from `pkgs.haskellPackages`. - [ ] Evaluation is taking a rather long time (5+ hours) in Hydra. - [ ] Some of the Buildkite pipeline steps don't work with the updated Haskell.nix. - [ ] Tests for windows are built not not executed. The tests should be run under wine. # Next PRs - [ ] Fix failures in sqlite tests on Windows ⇒ #918. - [ ] Fix failure in launch command on Windows. - [ ] Fix the UTF-8 text issues on Windows ⇒ #914. - [ ] Add code which tells the windows command prompt to interpret ANSI color codes. - [ ] Identify other test failures and fix. Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Michael Bishop <[email protected]>
The wallet failed with:
NUL: openFile: does not exist (No such file or directory)
This is due to runMigrationSilent which uses the silently library:
http://hackage.haskell.org/package/silently-1.2.5.1/docs/src/System.IO.Silently.html#line-27
To fix, we swap runMigrationSilent with runMigrationQuiet (added in
persistent-2.10.2).
rvl
force-pushed
the
rvl/703/fix-sqlite-windows
branch
from
526a981
to
23875ba
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 5, 2019
918: Fix Sqlite DB on Windows r=rvl a=rvl Relates to #703. Based on the branch of #888. # Overview The wallet failed with: NUL: openFile: does not exist (No such file or directory) This is due to runMigrationSilent which uses the silently library: http://hackage.haskell.org/package/silently-1.2.5.1/docs/src/System.IO.Silently.html#line-27 To fix, we swap `runMigrationQuiet` for `runMigrationSilent` on Windows. Co-authored-by: KtorZ <[email protected]> Co-authored-by: iohk-bors[bot] <43231472+iohk-bors[bot]@users.noreply.github.com> Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed |
27 tasks
|
Fixed base branch and cleared stack caches on Buildkite. bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 5, 2019
918: Fix Sqlite DB on Windows r=rvl a=rvl Relates to #703. Based on the branch of #888. # Overview The wallet failed with: NUL: openFile: does not exist (No such file or directory) This is due to runMigrationSilent which uses the silently library: http://hackage.haskell.org/package/silently-1.2.5.1/docs/src/System.IO.Silently.html#line-27 To fix, we swap `runMigrationQuiet` for `runMigrationSilent` on Windows. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed |
|
The integration tests failed due to #931. Retrying. bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 5, 2019
918: Fix Sqlite DB on Windows r=rvl a=rvl Relates to #703. Based on the branch of #888. # Overview The wallet failed with: NUL: openFile: does not exist (No such file or directory) This is due to runMigrationSilent which uses the silently library: http://hackage.haskell.org/package/silently-1.2.5.1/docs/src/System.IO.Silently.html#line-27 To fix, we swap `runMigrationQuiet` for `runMigrationSilent` on Windows. Co-authored-by: Rodney Lorrimar <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #703.
Based on the branch of #888.
Overview
The wallet failed with:
This is due to runMigrationSilent which uses the silently library:
http://hackage.haskell.org/package/silently-1.2.5.1/docs/src/System.IO.Silently.html#line-27
To fix, we swap
runMigrationQuietforrunMigrationSilenton Windows.