Integration tests: logging is shut down when CLI finished #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| , block0H | ||
| ] | ||
| let process = proc' (commandName @t) args | ||
| (out, _) <- collectStreams (10, 0) process |
There was a problem hiding this comment.
Hi @rvl. Are you able to say a little bit about where 10 and 0 came from here?
There was a problem hiding this comment.
These are the number of output lines to collect before finishing the test.
The collectStreams function is a bit fishy actually.
KtorZ
approved these changes
Oct 31, 2019
piotr-iohk
approved these changes
Oct 31, 2019
rvl
force-pushed
the
rvl/852/logging-shutdown-test
branch
from
0d4aad4
to
6021a59
Compare
paweljakubas
approved these changes
Oct 31, 2019
paweljakubas
force-pushed
the
rvl/852/logging-shutdown-test
branch
from
6021a59
to
a7e29d0
Compare
|
rebased against master |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 31, 2019
944: Integration tests: logging is shut down when CLI finished r=paweljakubas a=rvl Relates to #851. # Overview Adds integration test case for clean logging shutdown. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed |
paweljakubas
force-pushed
the
rvl/852/logging-shutdown-test
branch
from
a7e29d0
to
de6b2d8
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 31, 2019
944: Integration tests: logging is shut down when CLI finished r=paweljakubas a=rvl Relates to #851. # Overview Adds integration test case for clean logging shutdown. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed |
|
interesting : https://hydra.iohk.io/build/1303898/nixlog/31 |
This is a similar/the same error #931 that occurred on Buildkite and caused the Bors build to fail. |
|
Will try again 🤞 bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 1, 2019
944: Integration tests: logging is shut down when CLI finished r=rvl a=rvl Relates to #851. # Overview Adds integration test case for clean logging shutdown. Co-authored-by: Rodney Lorrimar <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #851.
Overview
Adds integration test case for clean logging shutdown.